lynxpoint/broadwell: Rename LP GPIO config global
Do not use the same name as the non-LP GPIO config. This allows checking at build-time that a mainboard uses the correct GPIO config format. Without this commit, there are no build-time errors when using the wrong format of GPIO config, but there would be undefined behavior at runtime. Tested by trying to build asrock/b85m_pro4 and hp/folio_9480m after toggling the `INTEL_LYNXPOINT_LP` Kconfig option (and trimming down the USB config arrays for asrock/b85m_pro4). In both cases, building failed because the necessary GPIO config global is not defined, as expected. Change-Id: Ib06507ef8179da22bdb27593daf972e788051f3a Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/51661 Reviewed-by: Nico Huber <nico.h@gmx.de> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
committed by
Patrick Georgi
parent
d12d24b039
commit
88f94a9635
@@ -90,7 +90,7 @@ void early_pch_init(void)
|
||||
pch_enable_bars();
|
||||
|
||||
#if CONFIG(INTEL_LYNXPOINT_LP)
|
||||
setup_pch_lp_gpios(mainboard_gpio_map);
|
||||
setup_pch_lp_gpios(mainboard_lp_gpio_map);
|
||||
#else
|
||||
setup_pch_gpios(&mainboard_gpio_map);
|
||||
#endif
|
||||
|
@@ -172,6 +172,6 @@ int gpio_is_native(int gpio_num);
|
||||
*/
|
||||
unsigned int get_gpios(const int *gpio_num_array);
|
||||
|
||||
extern const struct pch_lp_gpio_map mainboard_gpio_map[];
|
||||
extern const struct pch_lp_gpio_map mainboard_lp_gpio_map[];
|
||||
|
||||
#endif
|
||||
|
Reference in New Issue
Block a user