sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brox/var/jubilant: Enable devices on unprovisioned fw_config

Browse Source 
Add the condition of unprovisioned fw_config to enable all storages
and devices. It's for first boot on all storags and preliminary test
in factory when fw_config is unprovisioned.

BUG=None
TEST=Build jubilant firmware and boot to OS on storages when fw_config
     is unprovisioned and ensure all devices are enable.

Change-Id: Ia14632744c34548e2c201dfc58d82515cdd02df0
Signed-off-by: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84002
Reviewed-by: Tyler Wang <tyler.wang@quanta.corp-partner.google.com>
Reviewed-by: Kenneth Chan <kenneth.chan@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Ren Kuo 2024-08-21 15:40:46 +08:00 committed by Felix Held
parent 60d9121073
commit 89869144bf
3 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/brox/variants/jubilant/fw_config.c
View File

@ -60,7 +60,7 @@ static const struct pad_config nvme_disable_pads[] = {
static void fw_config_handle(void *unused) static void fw_config_handle(void *unused)
{ {
if (!fw_config_is_provisioned()) { if (!fw_config_is_provisioned()) {
printk(BIOS_WARNING, "FW_CONFIG is not provisioned. Exiting...\n"); printk(BIOS_WARNING, "FW_CONFIG is unprovisioned. Skip disable device's pads.\n");
return; return;
} }

7
src/mainboard/google/brox/variants/jubilant/overridetree.cb
View File

@ -232,6 +232,7 @@ chip soc/intel/alderlake
register "type" = "UPC_TYPE_INTERNAL" register "type" = "UPC_TYPE_INTERNAL"
device ref usb2_port4 on device ref usb2_port4 on
probe DB_USB DB_1A_LTE probe DB_USB DB_1A_LTE
probe unprovisioned
end end
end end
chip drivers/usb/acpi chip drivers/usb/acpi
@ -281,6 +282,7 @@ chip soc/intel/alderlake
register "type" = "UPC_TYPE_INTERNAL" register "type" = "UPC_TYPE_INTERNAL"
device ref usb3_port4 on device ref usb3_port4 on
probe DB_USB DB_1A_LTE probe DB_USB DB_1A_LTE
probe unprovisioned
end end
end end
end end
@ -308,6 +310,7 @@ chip soc/intel/alderlake
register "add_acpi_dma_property" = "true" register "add_acpi_dma_property" = "true"
device pci 00.0 on device pci 00.0 on
probe WIFI_BT WIFI_BT_PCIE probe WIFI_BT WIFI_BT_PCIE
probe unprovisioned
end end
end end
chip soc/intel/common/block/pcie/rtd3 chip soc/intel/common/block/pcie/rtd3
@ -317,6 +320,7 @@ chip soc/intel/alderlake
device generic 0 on end device generic 0 on end
end end
probe WIFI_BT WIFI_BT_PCIE probe WIFI_BT WIFI_BT_PCIE
probe unprovisioned
end end
device ref cnvi_wifi on device ref cnvi_wifi on
chip drivers/wifi/generic chip drivers/wifi/generic
@ -326,6 +330,7 @@ chip soc/intel/alderlake
device generic 0 on end device generic 0 on end
end end
probe WIFI_BT WIFI_BT_CNVI probe WIFI_BT WIFI_BT_CNVI
probe unprovisioned
end end
device ref ish on device ref ish on
chip drivers/intel/ish chip drivers/intel/ish
@ -441,6 +446,7 @@ chip soc/intel/alderlake
register "input_analog_gain" = "1" register "input_analog_gain" = "1"
device i2c 28 on device i2c 28 on
probe DB_USB DB_1A_LTE probe DB_USB DB_1A_LTE
probe unprovisioned
end end
end end
end end
@ -458,6 +464,7 @@ chip soc/intel/alderlake
register "enable_delay_ms" = "3" register "enable_delay_ms" = "3"
device spi 0 on device spi 0 on
probe FPMCU FPMCU_NUVOTON probe FPMCU FPMCU_NUVOTON
probe unprovisioned
end end
end # FPMCU end # FPMCU
end end

6
src/mainboard/google/brox/variants/jubilant/variant.c
View File

@ -9,7 +9,7 @@
void variant_update_soc_chip_config(struct soc_intel_alderlake_config *config) void variant_update_soc_chip_config(struct soc_intel_alderlake_config *config)
{ {
if (fw_config_probe(FW_CONFIG(WIFI_BT, WIFI_BT_CNVI))) { if (fw_config_probe(FW_CONFIG(WIFI_BT, WIFI_BT_CNVI)) || (!fw_config_is_provisioned())) {
printk(BIOS_INFO, "CNVi bluetooth enabled by fw_config\n"); printk(BIOS_INFO, "CNVi bluetooth enabled by fw_config\n");
config->cnvi_bt_core = true; config->cnvi_bt_core = true;
config->cnvi_bt_audio_offload = true; config->cnvi_bt_audio_offload = true;
@ -31,8 +31,8 @@ void variant_devtree_update(void)
struct device *ish = DEV_PTR(ish); struct device *ish = DEV_PTR(ish);
struct device *nvme_rp = DEV_PTR(pcie4_0); struct device *nvme_rp = DEV_PTR(pcie4_0);
if (fw_config_probe(FW_CONFIG(STORAGE, STORAGE_UNKNOWN))) { if (fw_config_probe(FW_CONFIG(STORAGE, STORAGE_UNKNOWN)) || (!fw_config_is_provisioned())) {
printk(BIOS_INFO, "fw_config storage is unknown so enable all storage devices.\n"); printk(BIOS_INFO, "fw_config is unprovisioned or storage is unknown so enable all storage's configs.\n");
return; return;
} }