soc/intel/{skl,cnl}: drop duplicate PM ACPI timer disabling
FSP already disables the PM ACPI timer, when EnableTcoTimer=0. Test: clevo/l140cu and supermicro/x11ssm-f have the PM ACPI timer disable bit set when EnableTcoTimer=0. Change-Id: If370d3acf87ae6d1d7c64bf27228877cdd92ab2d Signed-off-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/45954 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
@@ -43,7 +43,6 @@ config CPU_SPECIFIC_OPTIONS
|
||||
select REG_SCRIPT
|
||||
select SA_ENABLE_DPR
|
||||
select PMC_GLOBAL_RESET_ENABLE_LOCK
|
||||
select PMC_LOW_POWER_MODE_PROGRAM
|
||||
select SOC_INTEL_COMMON
|
||||
select SOC_INTEL_COMMON_ACPI_WAKE_SOURCE
|
||||
select SOC_INTEL_COMMON_BLOCK
|
||||
|
@@ -62,16 +62,6 @@ static void pch_finalize_script(struct device *dev)
|
||||
*/
|
||||
pch_thermal_configuration();
|
||||
|
||||
/*
|
||||
* Disable ACPI PM timer based on dt policy
|
||||
*
|
||||
* Disabling ACPI PM timer is necessary for XTAL OSC shutdown.
|
||||
* Disabling ACPI PM timer also switches off TCO
|
||||
*/
|
||||
|
||||
if (config->PmTimerDisabled)
|
||||
pmc_disable_acpi_timer();
|
||||
|
||||
/* we should disable Heci1 based on the devicetree policy */
|
||||
if (config->HeciEnabled == 0)
|
||||
pch_disable_heci();
|
||||
|
Reference in New Issue
Block a user