* Convert the NSC code to the common code structure all other Super I/Os use.
* Improve the --verbose output a bit more. Print the "Probing..." text for all Super I/Os and if a Super I/O is not known, show the data we were able to read from the chip (what data this is is very vendor/chip specific). * Thus the common no_superio_found() is dropped, it's not useful. The "read from 0x20" part was wrong for all Super I/Os other than the NSC ones anyway. * Winbond: For the 'olddevid' only use bits 3..0, mask away the others. * SMSC: Print which ID registers we try to read (in --verbose mode). * Minor cosmetic fixes. * Rename PC8374 to PC8374L (as per datasheet). * Rename probe_idregs_simple() to probe_idregs_nsc(). * Rename dump_readable_ns8374() to dump_readable_pc8374l(). Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Stefan Reinauer <stepan@coresystems.de> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@2821 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
@@ -136,6 +136,8 @@ void probe_idregs_fintek(uint16_t port)
|
||||
{
|
||||
uint16_t vid, did;
|
||||
|
||||
probing_for("Fintek", "", port);
|
||||
|
||||
enter_conf_mode_winbond_fintek_ite_8787(port);
|
||||
|
||||
did = regval(port, DEVICE_ID_BYTE1_REG);
|
||||
@@ -145,12 +147,13 @@ void probe_idregs_fintek(uint16_t port)
|
||||
vid |= (regval(port, VENDOR_ID_BYTE2_REG) << 8);
|
||||
|
||||
if (vid != FINTEK_VENDOR_ID || superio_unknown(reg_table, did)) {
|
||||
no_superio_found("Fintek", "", port);
|
||||
if (verbose)
|
||||
printf(NOTFOUND "vid=0x%04x, id=0x%04x\n", vid, did);
|
||||
exit_conf_mode_winbond_fintek_ite_8787(port);
|
||||
return;
|
||||
}
|
||||
|
||||
printf("Found Fintek %s (vid=0x%04x, id=0x%04x) at port=0x%x\n",
|
||||
printf("Found Fintek %s (vid=0x%04x, id=0x%04x) at 0x%x\n",
|
||||
get_superio_name(reg_table, did), vid, did, port);
|
||||
|
||||
dump_superio("Fintek", reg_table, port, did);
|
||||
|
Reference in New Issue
Block a user