From 8bf53c01620deeace3640b831d42d67f1d10e21b Mon Sep 17 00:00:00 2001 From: Nicholas Chin Date: Mon, 30 Jan 2023 22:48:21 -0700 Subject: [PATCH] util/scripts/show_platforms.sh: Fix reStructuredText table output reStructuredText grid tables require row separators otherwise the rows get concatenated into a single cell for each column. Representative output of previous behavior: ```eval_rst +-------------------------+-------------------+------------+----------+ | Vendor/Board | Processor | Date added | Brd type | +=========================+===================+============+==========+ | 51nb/x210 | INTEL_KABYLAKE | 2020-03-16 | laptop | | acer/aspire_vn7_572g | INTEL_SKYLAKE | 2022-01-28 | laptop | | acer/g43t-am3 | INTEL_X4X | 2020-09-28 | desktop | +-------------------------+-------------------+------------+----------+ ``` Representative output of corrected behavior: ```eval_rst +-------------------------+-------------------+------------+----------+ | Vendor/Board | Processor | Date added | Brd type | +=========================+===================+============+==========+ | 51nb/x210 | INTEL_KABYLAKE | 2020-03-16 | laptop | +-------------------------+-------------------+------------+----------+ | acer/aspire_vn7_572g | INTEL_SKYLAKE | 2022-01-28 | laptop | +-------------------------+-------------------+------------+----------+ | acer/g43t-am3 | INTEL_X4X | 2020-09-28 | desktop | +-------------------------+-------------------+------------+----------+ ``` Change-Id: I83be58dd2c34c65ae2c65cf2bd98330936fb6f6a Signed-off-by: Nicholas Chin Reviewed-on: https://review.coreboot.org/c/coreboot/+/72624 Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas Reviewed-by: Matt DeVillier --- util/scripts/show_platforms.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/scripts/show_platforms.sh b/util/scripts/show_platforms.sh index 39d77725a8..410a84cf42 100755 --- a/util/scripts/show_platforms.sh +++ b/util/scripts/show_platforms.sh @@ -40,8 +40,8 @@ for file in "${platforms[@]}"; do for chip in ${chips}; do printf "| %-29s | %-22s | %-10s | %-9s |\n" "${platformname}" "${chip}" "${create_date}" "${platform_type}" + echo "+-------------------------------+------------------------+------------+-----------+" done done -echo "+-------------------------------+------------------------+------------+-----------+" echo '```'