sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/trace: Remove TRACE support

Browse Source 
Looks like the option is generally not compatible with
garbage collections.

Nothing gets inlined, for example is_smp_boot() no longer
evaluates to constant false and thus the symbols from
secondary.S would need to be present for the build to pass
even if we set SMP=n.

Also the addresses of relocatable ramstage are currently
not normalised on the logs, so util/genprof would be unable
dress those.

Change-Id: I0b6f310e15e6f4992cd054d288903fea8390e5cf
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45757
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Kyösti Mälkki
2020-07-24 15:54:31 +03:00
committed by Nico Huber
parent 5e053af7a6
commit 8c99c27df1
14 changed files with 1 additions and 256 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/console/printk.c
View File

@@ -10,7 +10,6 @@
#include <console/vtxprintf.h>
#include <smp/spinlock.h>
#include <smp/node.h>
#include <trace.h>
#include <timer.h>
DECLARE_SPIN_LOCK(console_lock)
@@ -81,7 +80,6 @@ int do_vprintk(int msg_level, const char *fmt, va_list args)
if (log_this < CONSOLE_LOG_FAST)
return 0;
DISABLE_TRACE;
spin_lock(&console_lock);
console_time_run();
@@ -96,7 +94,6 @@ int do_vprintk(int msg_level, const char *fmt, va_list args)
console_time_stop();
spin_unlock(&console_lock);
ENABLE_TRACE;
return i;
}