sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/trace: Remove TRACE support

Browse Source 
Looks like the option is generally not compatible with
garbage collections.

Nothing gets inlined, for example is_smp_boot() no longer
evaluates to constant false and thus the symbols from
secondary.S would need to be present for the build to pass
even if we set SMP=n.

Also the addresses of relocatable ramstage are currently
not normalised on the logs, so util/genprof would be unable
dress those.

Change-Id: I0b6f310e15e6f4992cd054d288903fea8390e5cf
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45757
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Kyösti Mälkki
2020-07-24 15:54:31 +03:00
committed by Nico Huber
parent 5e053af7a6
commit 8c99c27df1
14 changed files with 1 additions and 256 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/console/vsprintf.c
View File

@ -2,7 +2,6 @@
#include <console/vtxprintf.h>
#include <string.h>
#include <trace.h>
struct vsnprintf_context {
char *str_buf;
@ -24,16 +23,12 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
int i;
struct vsnprintf_context ctx;
DISABLE_TRACE;
ctx.str_buf = buf;
ctx.buf_limit = size ? size - 1 : 0;
i = vtxprintf(str_tx_byte, fmt, args, &ctx);
if (size)
*ctx.str_buf = '\0';
ENABLE_TRACE;
return i;
}