sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Documentation/.../gerrit_guidelines: Remove trailing colon from headings

Browse Source 
They are unnecessary in headings, and look slightly irritating in the
table of contents.

Change-Id: I7344026f5753aebdd73f9fe414e96730c823ac26
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-on: https://review.coreboot.org/28832
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Jonathan Neuschäfer
2018-09-30 20:10:04 +02:00
committed by Patrick Georgi
parent 0d61f3fcde
commit 8ded4ce1aa
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
Documentation/getting_started/gerrit_guidelines.md
View File

@@ -13,8 +13,8 @@ here, please discuss it in the mailing list to get this document updated.
Don't just assume that it's okay, even if someone on IRC says it is. Don't just assume that it's okay, even if someone on IRC says it is.
Summary: Summary
-------- -------
These are the expectations for committing, reviewing, and submitting code These are the expectations for committing, reviewing, and submitting code
into coreboot git and gerrit. While breaking individual rules may not have into coreboot git and gerrit. While breaking individual rules may not have
immediate consequences, the coreboot leadership may act on repeated or immediate consequences, the coreboot leadership may act on repeated or
@@ -33,8 +33,8 @@ addresses.
* Don’t submit patches that you know will break other platforms. * Don’t submit patches that you know will break other platforms.
More detail: More detail
------------ -----------
* Don't violate the licenses. If you're submitting code that you didn't * Don't violate the licenses. If you're submitting code that you didn't
write yourself, make sure the license is compatible with the license of the write yourself, make sure the license is compatible with the license of the
project you're submitting the changes to. If you’re submitting code that project you're submitting the changes to. If you’re submitting code that
@@ -98,8 +98,8 @@ must at least provide a path that will allow other platforms to continue
working. working.
Recommendations for gerrit activity: Recommendations for gerrit activity
------------------------------------ -----------------------------------
These guidelines are less strict than the ones listed above. These are more These guidelines are less strict than the ones listed above. These are more
of the “good idea” variety. You are requested to follow the below of the “good idea” variety. You are requested to follow the below
guidelines, but there will probably be no actual consequences if they’re guidelines, but there will probably be no actual consequences if they’re
@@ -251,8 +251,8 @@ The script 'util/gitconfig/rebase.sh' can be used to help automate this.
Other tags such as 'Commit-Queue' can simply be removed. Other tags such as 'Commit-Queue' can simply be removed.
Expectations contributors should have: Expectations contributors should have
-------------------------------------- -------------------------------------
* Don't expect that people will review your patch unless you ask them to. * Don't expect that people will review your patch unless you ask them to.
Adding other people as reviewers is the easiest way. Asking for reviews for Adding other people as reviewers is the easiest way. Asking for reviews for
individual patches in the IRC channel, or by sending a direct request to an individual patches in the IRC channel, or by sending a direct request to an