fsp_baytrail: Fix ACPI 'Object is not referenced' warnings
The ACPI compiler is trying to be helpful in letting us know that we're not using various fields in the MCRS 'ResourceTemplate' when we define it inside of the _CRS method. Since we're not intending to use those objects in the method, it shouldn't be an issue, but the warning is annoying. Moving the creation of the MCRS object to outside of the _CRS method and referencing it from there solves this problem. Change-Id: I222642e9a93f3078b46ed74f57b83a5834657abf Signed-off-by: Martin Roth <martin.roth@se-eng.com> Reviewed-on: http://review.coreboot.org/7499 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
This commit is contained in:
Martin Roth
Martin Roth
@@ -56,126 +56,126 @@ Name(_CID,EISAID("PNP0A03")) // PCI
|
|||||||
Name(_ADR, 0)
|
Name(_ADR, 0)
|
||||||
Name(_BBN, 0)
|
Name(_BBN, 0)
|
||||||
|
|
||||||
|
Name (MCRS, ResourceTemplate()
|
||||||
|
{
|
||||||
|
// Bus Numbers
|
||||||
|
WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
|
||||||
|
0x0000, 0x0000, 0x00ff, 0x0000, 0x0100,,, PB00)
|
||||||
|
|
||||||
|
// IO Region 0
|
||||||
|
DWordIO (ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange,
|
||||||
|
0x0000, 0x0000, 0x0cf7, 0x0000, 0x0cf8,,, PI00)
|
||||||
|
|
||||||
|
// PCI Config Space
|
||||||
|
Io (Decode16, 0x0cf8, 0x0cf8, 0x0001, 0x0008)
|
||||||
|
|
||||||
|
// IO Region 1
|
||||||
|
DWordIO (ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange,
|
||||||
|
0x0000, 0x0d00, 0xffff, 0x0000, 0xf300,,, PI01)
|
||||||
|
|
||||||
|
// VGA memory (0xa0000-0xbffff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000a0000, 0x000bffff, 0x00000000,
|
||||||
|
0x00020000,,, ASEG)
|
||||||
|
|
||||||
|
// OPROM reserved (0xc0000-0xc3fff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000c0000, 0x000c3fff, 0x00000000,
|
||||||
|
0x00004000,,, OPR0)
|
||||||
|
|
||||||
|
// OPROM reserved (0xc4000-0xc7fff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000c4000, 0x000c7fff, 0x00000000,
|
||||||
|
0x00004000,,, OPR1)
|
||||||
|
|
||||||
|
// OPROM reserved (0xc8000-0xcbfff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000c8000, 0x000cbfff, 0x00000000,
|
||||||
|
0x00004000,,, OPR2)
|
||||||
|
|
||||||
|
// OPROM reserved (0xcc000-0xcffff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000cc000, 0x000cffff, 0x00000000,
|
||||||
|
0x00004000,,, OPR3)
|
||||||
|
|
||||||
|
// OPROM reserved (0xd0000-0xd3fff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000d0000, 0x000d3fff, 0x00000000,
|
||||||
|
0x00004000,,, OPR4)
|
||||||
|
|
||||||
|
// OPROM reserved (0xd4000-0xd7fff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000d4000, 0x000d7fff, 0x00000000,
|
||||||
|
0x00004000,,, OPR5)
|
||||||
|
|
||||||
|
// OPROM reserved (0xd8000-0xdbfff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000d8000, 0x000dbfff, 0x00000000,
|
||||||
|
0x00004000,,, OPR6)
|
||||||
|
|
||||||
|
// OPROM reserved (0xdc000-0xdffff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000dc000, 0x000dffff, 0x00000000,
|
||||||
|
0x00004000,,, OPR7)
|
||||||
|
|
||||||
|
// BIOS Extension (0xe0000-0xe3fff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000e0000, 0x000e3fff, 0x00000000,
|
||||||
|
0x00004000,,, ESG0)
|
||||||
|
|
||||||
|
// BIOS Extension (0xe4000-0xe7fff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000e4000, 0x000e7fff, 0x00000000,
|
||||||
|
0x00004000,,, ESG1)
|
||||||
|
|
||||||
|
// BIOS Extension (0xe8000-0xebfff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000e8000, 0x000ebfff, 0x00000000,
|
||||||
|
0x00004000,,, ESG2)
|
||||||
|
|
||||||
|
// BIOS Extension (0xec000-0xeffff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000ec000, 0x000effff, 0x00000000,
|
||||||
|
0x00004000,,, ESG3)
|
||||||
|
|
||||||
|
// System BIOS (0xf0000-0xfffff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0x000f0000, 0x000fffff, 0x00000000,
|
||||||
|
0x00010000,,, FSEG)
|
||||||
|
|
||||||
|
// PCI Memory Region (Top of memory-0xfeafffff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0xfea00000, 0xfeafffff, 0x00000000,
|
||||||
|
0x00100000,,, PMEM)
|
||||||
|
|
||||||
|
// TPM Area (0xfed40000-0xfed44fff)
|
||||||
|
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
||||||
|
Cacheable, ReadWrite,
|
||||||
|
0x00000000, 0xfed40000, 0xfed44fff, 0x00000000,
|
||||||
|
0x00005000,,, TPMR)
|
||||||
|
})
|
||||||
|
|
||||||
Method (_CRS, 0, Serialized)
|
Method (_CRS, 0, Serialized)
|
||||||
{
|
{
|
||||||
Name (MCRS, ResourceTemplate()
|
|
||||||
{
|
|
||||||
// Bus Numbers
|
|
||||||
WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
|
|
||||||
0x0000, 0x0000, 0x00ff, 0x0000, 0x0100,,, PB00)
|
|
||||||
|
|
||||||
// IO Region 0
|
|
||||||
DWordIO (ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange,
|
|
||||||
0x0000, 0x0000, 0x0cf7, 0x0000, 0x0cf8,,, PI00)
|
|
||||||
|
|
||||||
// PCI Config Space
|
|
||||||
Io (Decode16, 0x0cf8, 0x0cf8, 0x0001, 0x0008)
|
|
||||||
|
|
||||||
// IO Region 1
|
|
||||||
DWordIO (ResourceProducer, MinFixed, MaxFixed, PosDecode, EntireRange,
|
|
||||||
0x0000, 0x0d00, 0xffff, 0x0000, 0xf300,,, PI01)
|
|
||||||
|
|
||||||
// VGA memory (0xa0000-0xbffff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000a0000, 0x000bffff, 0x00000000,
|
|
||||||
0x00020000,,, ASEG)
|
|
||||||
|
|
||||||
// OPROM reserved (0xc0000-0xc3fff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000c0000, 0x000c3fff, 0x00000000,
|
|
||||||
0x00004000,,, OPR0)
|
|
||||||
|
|
||||||
// OPROM reserved (0xc4000-0xc7fff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000c4000, 0x000c7fff, 0x00000000,
|
|
||||||
0x00004000,,, OPR1)
|
|
||||||
|
|
||||||
// OPROM reserved (0xc8000-0xcbfff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000c8000, 0x000cbfff, 0x00000000,
|
|
||||||
0x00004000,,, OPR2)
|
|
||||||
|
|
||||||
// OPROM reserved (0xcc000-0xcffff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000cc000, 0x000cffff, 0x00000000,
|
|
||||||
0x00004000,,, OPR3)
|
|
||||||
|
|
||||||
// OPROM reserved (0xd0000-0xd3fff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000d0000, 0x000d3fff, 0x00000000,
|
|
||||||
0x00004000,,, OPR4)
|
|
||||||
|
|
||||||
// OPROM reserved (0xd4000-0xd7fff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000d4000, 0x000d7fff, 0x00000000,
|
|
||||||
0x00004000,,, OPR5)
|
|
||||||
|
|
||||||
// OPROM reserved (0xd8000-0xdbfff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000d8000, 0x000dbfff, 0x00000000,
|
|
||||||
0x00004000,,, OPR6)
|
|
||||||
|
|
||||||
// OPROM reserved (0xdc000-0xdffff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000dc000, 0x000dffff, 0x00000000,
|
|
||||||
0x00004000,,, OPR7)
|
|
||||||
|
|
||||||
// BIOS Extension (0xe0000-0xe3fff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000e0000, 0x000e3fff, 0x00000000,
|
|
||||||
0x00004000,,, ESG0)
|
|
||||||
|
|
||||||
// BIOS Extension (0xe4000-0xe7fff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000e4000, 0x000e7fff, 0x00000000,
|
|
||||||
0x00004000,,, ESG1)
|
|
||||||
|
|
||||||
// BIOS Extension (0xe8000-0xebfff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000e8000, 0x000ebfff, 0x00000000,
|
|
||||||
0x00004000,,, ESG2)
|
|
||||||
|
|
||||||
// BIOS Extension (0xec000-0xeffff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000ec000, 0x000effff, 0x00000000,
|
|
||||||
0x00004000,,, ESG3)
|
|
||||||
|
|
||||||
// System BIOS (0xf0000-0xfffff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0x000f0000, 0x000fffff, 0x00000000,
|
|
||||||
0x00010000,,, FSEG)
|
|
||||||
|
|
||||||
// PCI Memory Region (Top of memory-0xfeafffff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0xfea00000, 0xfeafffff, 0x00000000,
|
|
||||||
0x00100000,,, PMEM)
|
|
||||||
|
|
||||||
// TPM Area (0xfed40000-0xfed44fff)
|
|
||||||
DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,
|
|
||||||
Cacheable, ReadWrite,
|
|
||||||
0x00000000, 0xfed40000, 0xfed44fff, 0x00000000,
|
|
||||||
0x00005000,,, TPMR)
|
|
||||||
})
|
|
||||||
|
|
||||||
// Update PCI resource area
|
// Update PCI resource area
|
||||||
CreateDwordField(MCRS, PMEM._MIN, PMIN)
|
CreateDwordField(MCRS, ^PMEM._MIN, PMIN)
|
||||||
CreateDwordField(MCRS, PMEM._MAX, PMAX)
|
CreateDwordField(MCRS, ^PMEM._MAX, PMAX)
|
||||||
CreateDwordField(MCRS, PMEM._LEN, PLEN)
|
CreateDwordField(MCRS, ^PMEM._LEN, PLEN)
|
||||||
|
|
||||||
// TOLM is BMBOUND accessible from IOSF so is saved in NVS
|
// TOLM is BMBOUND accessible from IOSF so is saved in NVS
|
||||||
Store (\TOLM, PMIN)
|
Store (\TOLM, PMIN)
|
||||||
|
|||||||
Reference in New Issue
Block a user