sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/fsp_broadwell_de: Use DIMM numbers relative to channel

Browse Source 
Currently "DIMM numbers" increase monotonically for all the channels. However,
commonly DIMMS are numerated on per-channel basis. This change makes numeration
match the convention.

TEST=on OCP monolake, run dmidecode tool and see that "Locator" field matches
expectation.

Change-Id: I3e7858545471867a0210e1b9ef646529b8e2a31c
Signed-off-by: Andrey Petrov <anpetrov@fb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35318
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Andrey Petrov
2019-09-10 11:14:00 -07:00
committed by Martin Roth
parent 65562cd654
commit 91f955e31f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/intel/fsp_broadwell_de/romstage/memory.c
View File

@@ -54,7 +54,7 @@ void save_dimm_info(void)
dimm_attr dimm = {0}; dimm_attr dimm = {0};
u8 *spd_data = blk.spd_array[index]; u8 *spd_data = blk.spd_array[index];
if (spd_decode_ddr4(&dimm, spd_data) == SPD_STATUS_OK) if (spd_decode_ddr4(&dimm, spd_data) == SPD_STATUS_OK)
spd_add_smbios17_ddr4(channel, index, dclk_mhz, &dimm); spd_add_smbios17_ddr4(channel, slot, dclk_mhz, &dimm);
index++; index++;
} }
} }