sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/psp_smm: introduce and use send_psp_command_smm

Browse Source 
When sending mailbox commands to the PSP from SMM, the SMM flag needs to
be set right before sending the mailbox command and cleared right after
the command is sent. In order to not have this code duplicated, factor
it out into a function.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I3628463dece9d11703d5a068fe7c604108b69c1f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83700
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
This commit is contained in:
Felix Held
2024-07-30 14:12:21 +02:00
parent e6c40f6272
commit 930d0b16cc
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/soc/amd/common/block/psp/psp_smm.c
View File

@@ -47,6 +47,17 @@ static void clear_smm_flag(void)
smm_flag = 0; smm_flag = 0;
} }
static int send_psp_command_smm(u32 command, void *buffer)
{
int cmd_status;
set_smm_flag();
cmd_status = send_psp_command(command, buffer);
clear_smm_flag();
return cmd_status;
}
/* /*
* The MBOX_BIOS_CMD_SMM_INFO PSP mailbox command doesn't necessarily need be sent from SMM, * The MBOX_BIOS_CMD_SMM_INFO PSP mailbox command doesn't necessarily need be sent from SMM,
* but doing so allows the linker to sort out the addresses of c2p_buffer, p2c_buffer and * but doing so allows the linker to sort out the addresses of c2p_buffer, p2c_buffer and
@@ -83,9 +94,7 @@ int psp_notify_smm(void)
printk(BIOS_DEBUG, "PSP: Notify SMM info... "); printk(BIOS_DEBUG, "PSP: Notify SMM info... ");
set_smm_flag(); cmd_status = send_psp_command_smm(MBOX_BIOS_CMD_SMM_INFO, &buffer);
cmd_status = send_psp_command(MBOX_BIOS_CMD_SMM_INFO, &buffer);
clear_smm_flag();
/* buffer's status shouldn't change but report it if it does */ /* buffer's status shouldn't change but report it if it does */
psp_print_cmd_status(cmd_status, &buffer.header); psp_print_cmd_status(cmd_status, &buffer.header);
@@ -113,9 +122,7 @@ void psp_notify_sx_info(u8 sleep_type)
buffer->sleep_type = sleep_type; buffer->sleep_type = sleep_type;
set_smm_flag(); cmd_status = send_psp_command_smm(MBOX_BIOS_CMD_SX_INFO, buffer);
cmd_status = send_psp_command(MBOX_BIOS_CMD_SX_INFO, buffer);
clear_smm_flag();
/* buffer's status shouldn't change but report it if it does */ /* buffer's status shouldn't change but report it if it does */
psp_print_cmd_status(cmd_status, &buffer->header); psp_print_cmd_status(cmd_status, &buffer->header);