sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/../thermal: Drop ltt_value local variable

Browse Source 
Using the `GET_LTT_VALUE` macro directly instead of 'ltt_value' local
variable.

BUG=b:193774296

Change-Id: I791766bf2a78fa30dbba8cf4ad8a50e44f0e73ed
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Subrata Banik
2021-11-15 12:10:56 +05:30
parent 4ab77addc5
commit 94030cfa55
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/soc/intel/common/block/thermal/thermal.c
View File

@@ -11,6 +11,7 @@
#define MAX_TRIP_TEMP 205 #define MAX_TRIP_TEMP 205
/* This is the safest default Trip Temp value */ /* This is the safest default Trip Temp value */
#define DEFAULT_TRIP_TEMP 50 #define DEFAULT_TRIP_TEMP 50
/* Trip Point Temp = (LTT / 2 - 50 degree C) */
#define GET_LTT_VALUE(x) (((x) + 50) * (2)) #define GET_LTT_VALUE(x) (((x) + 50) * (2))
static uint8_t get_thermal_trip_temp(void) static uint8_t get_thermal_trip_temp(void)
@@ -24,7 +25,6 @@ static uint8_t get_thermal_trip_temp(void)
/* PCH Low Temp Threshold (LTT) */ /* PCH Low Temp Threshold (LTT) */
static uint16_t pch_get_ltt_value(struct device *dev) static uint16_t pch_get_ltt_value(struct device *dev)
{ {
uint16_t ltt_value;
uint8_t thermal_config; uint8_t thermal_config;
thermal_config = get_thermal_trip_temp(); thermal_config = get_thermal_trip_temp();
@@ -34,10 +34,7 @@ static uint16_t pch_get_ltt_value(struct device *dev)
if (thermal_config > MAX_TRIP_TEMP) if (thermal_config > MAX_TRIP_TEMP)
die("Input PCH temp trip is higher than allowed range!"); die("Input PCH temp trip is higher than allowed range!");
/* Trip Point Temp = (LTT / 2 - 50 degree C) */ return GET_LTT_VALUE(thermal_config);
ltt_value = GET_LTT_VALUE(thermal_config);
return ltt_value;
} }
/* Enable thermal sensor power management */ /* Enable thermal sensor power management */