sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

helpers: Add GENMASK macro

Browse Source 
The GENMASK is defined in multiple files (with various names such as
MASKBIT), which sets certain consecutive bits to 1 and leaves the others
to 0. To avoid duplicate macros, add GENMASK macro to helpers.h.

GENMASK(high, low) sets bits from `high` to `low` (inclusive) to 1. For
example, GENMASK(39, 21) gives us the 64-bit vector 0x000000ffffe00000.

Remove duplicate macro definitions. Also utilize GENMASK for _BF_MASK in
mmio.h.

BUG=none
TEST=make tests/commonlib/bsd/helpers-test
TEST=emerge-cherry coreboot
BRANCH=none

Change-Id: If2e7c4827d8a7d27688534593b556a72f16f0c2b
Signed-off-by: Yu-Ping Wu <yupingso@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56543
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
This commit is contained in:
Yu-Ping Wu
2021-07-23 16:17:11 +08:00
committed by Paul Fagerburg
parent 5d71994c02
commit 941db0e55c
7 changed files with 33 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/commonlib/bsd/include/commonlib/bsd/helpers.h
View File

@ -54,6 +54,9 @@
#define POWER_OF_2(x) (1ULL << (x))
/* Set bits from `high` to `low` (inclusive). */
#define GENMASK(high, low) (((~0ULL) << (low)) & (~0ULL >> (63 - (high))))
#define DIV_ROUND_UP(x, y) ({ \
__typeof__(x) _div_local_x = (x); \
__typeof__(y) _div_local_y = (y); \