sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cbfstool: Change FMD annotation to flags

Browse Source 
The idea of "annotation" for firmware sections was pretty flexible, but
in future we will want multiple attributes applied to same area. For
example, indicate the section must be preserved when updating firmware
so serial number or MAC address can be preserved.

The solution here is to extend annotation so it can take multiple
identifiers (flags) in a row. For example, to declare a 64KB COREBOOT
section as CBFS using annotation:

 COREBOOT(CBFS)@0x0 64k

If there's a new flag "PRESERVE" indicating the section must be
preserved before update, we can declare it following CBFS flag:

 COREBOOT(CBFS PRESERVE)@0x0 64k

The flags are directly parsed in fmd_parser, and stored in an union
flashmap_flags. Output modules can choose to ignore or process the
flags.

Currently the only supported flag is "CBFS" (for backward compatible
with annotation). There will be more new flags in follow up patches.

BUG=chromium:936768
TEST=make; boots on x86 "google/eve" and arm "google/kukui" devices

Change-Id: Ie2d99f570e6faff6ed3a4344d6af7526a4515fae
Signed-off-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31706
Reviewed-by: Julius Werner <jwerner@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Hung-Te Lin
2019-03-04 14:28:37 +08:00
committed by Patrick Georgi
parent 7362768c50
commit 9497fcb742
9 changed files with 365 additions and 321 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
util/cbfstool/fmd_parser.h_shipped
View File

@@ -1,8 +1,8 @@
/* A Bison parser, made by GNU Bison 3.0.2. */
/* A Bison parser, made by GNU Bison 3.0.4. */
/* Bison interface for Yacc-like parsers in C
Copyright (C) 1984, 1989-1990, 2000-2013 Free Software Foundation, Inc.
Copyright (C) 1984, 1989-1990, 2000-2015 Free Software Foundation, Inc.
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -40,7 +40,7 @@
extern int yydebug;
#endif
/* "%code requires" blocks. */
#line 37 "fmd_parser.y" /* yacc.c:1909 */
#line 34 "fmd_parser.y" /* yacc.c:1909 */
#include "fmd.h"
#include "option.h"
@@ -60,9 +60,9 @@ struct descriptor_list {
extern struct flashmap_descriptor *res;
struct flashmap_descriptor *parse_descriptor(char *name,
struct unsigned_option offset, struct unsigned_option size,
struct descriptor_list children);
struct flashmap_descriptor *parse_descriptor(
char *name, union flashmap_flags flags, struct unsigned_option offset,
struct unsigned_option size, struct descriptor_list children);
void yyerror(const char *s);
#line 69 "y.tab.h" /* yacc.c:1909 */
@@ -74,29 +74,34 @@ void yyerror(const char *s);
{
INTEGER = 258,
OCTAL = 259,
STRING = 260
STRING = 260,
FLAG_CBFS = 261
};
#endif
/* Tokens. */
#define INTEGER 258
#define OCTAL 259
#define STRING 260
#define FLAG_CBFS 261
/* Value type. */
#if ! defined YYSTYPE && ! defined YYSTYPE_IS_DECLARED
typedef union YYSTYPE YYSTYPE;
union YYSTYPE
{
#line 29 "fmd_parser.y" /* yacc.c:1909 */
#line 25 "fmd_parser.y" /* yacc.c:1909 */
unsigned intval;
char *strval;
struct unsigned_option maybe_intval;
struct flashmap_descriptor *region_ptr;
union flashmap_flags flags;
struct descriptor_list region_listhdr;
#line 99 "y.tab.h" /* yacc.c:1909 */
#line 102 "y.tab.h" /* yacc.c:1909 */
};
typedef union YYSTYPE YYSTYPE;
# define YYSTYPE_IS_TRIVIAL 1
# define YYSTYPE_IS_DECLARED 1
#endif