From 94bfdd12821d0473e8bac1920342b0271a3771d5 Mon Sep 17 00:00:00 2001 From: Elyes Haouas Date: Mon, 27 May 2024 10:31:19 +0200 Subject: [PATCH] tree: Remove unused header is used to define macros for handling variable argument lists in functions like printf. It does not depend on the string or memory manipulation functions provided by . So let follow conventions and include only the necessary headers in each header file. Change-Id: I07ffc65b7feefb8ec4ab8dd268113f9ed8d24685 Signed-off-by: Elyes Haouas Reviewed-on: https://review.coreboot.org/c/coreboot/+/82664 Reviewed-by: Maximilian Brune Tested-by: build bot (Jenkins) --- src/include/stdarg.h | 3 +-- src/include/string.h | 1 - src/soc/amd/common/psp_verstage/psp_verstage.c | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/include/stdarg.h b/src/include/stdarg.h index c5a8cd8dbe..f55fcc3019 100644 --- a/src/include/stdarg.h +++ b/src/include/stdarg.h @@ -1,8 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /** - * Note: This file is only for POSIX compatibility, and is meant to be - * chain-included via string.h. + * Note: This file is only for POSIX compatibility. */ #ifndef STDARG_H diff --git a/src/include/string.h b/src/include/string.h index 92ea5e5f7f..4a06556d6d 100644 --- a/src/include/string.h +++ b/src/include/string.h @@ -3,7 +3,6 @@ #ifndef STRING_H #define STRING_H -#include /* IWYU pragma: export */ #include #include /* IWYU pragma: export */ diff --git a/src/soc/amd/common/psp_verstage/psp_verstage.c b/src/soc/amd/common/psp_verstage/psp_verstage.c index e71d75ac32..54945b9236 100644 --- a/src/soc/amd/common/psp_verstage/psp_verstage.c +++ b/src/soc/amd/common/psp_verstage/psp_verstage.c @@ -21,7 +21,6 @@ #include #include #include -#include #include extern char _bss_start, _bss_end;