sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya/var/marasov: Remove __weak for memory override

Browse Source 
Drop the __weak qualifier as this function is not overridden.

BUG=b:260565911
BRANCH=firmware-brya-14505.B
TEST=emerge-brya coreboot chromeos-bootimage

Signed-off-by: Frank Chu <Frank_Chu@pegatron.corp-partner.google.com>
Change-Id: Ica25b2bc4325ff9d27be672926b4e3b550c86e96
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70235
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Frank Chu <frank_chu@pegatron.corp-partner.google.com>
Reviewed-by: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com>
This commit is contained in:
Frank Chu 2022-12-02 11:55:57 +08:00 committed by Eric Lai
parent 1400875123
commit 951fb00d4e
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/mainboard/google/brya/variants/marasov/memory.c
View File

@ -70,12 +70,12 @@ static const struct mb_cfg baseboard_memcfg = {
.UserBd = BOARD_TYPE_MOBILE, .UserBd = BOARD_TYPE_MOBILE,
}; };
const struct mb_cfg *__weak variant_memory_params(void) const struct mb_cfg *variant_memory_params(void)
{ {
return &baseboard_memcfg; return &baseboard_memcfg;
} }
int __weak variant_memory_sku(void) int variant_memory_sku(void)
{ {
/* /*
* Memory configuration board straps * Memory configuration board straps
@ -92,7 +92,7 @@ int __weak variant_memory_sku(void)
return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios)); return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios));
} }
bool __weak variant_is_half_populated(void) bool variant_is_half_populated(void)
{ {
/* /*
* Ideally half_populated is used in platforms with multiple channels to * Ideally half_populated is used in platforms with multiple channels to
@ -106,7 +106,7 @@ bool __weak variant_is_half_populated(void)
return gpio_get(GPP_E13); return gpio_get(GPP_E13);
} }
void __weak variant_get_spd_info(struct mem_spd *spd_info) void variant_get_spd_info(struct mem_spd *spd_info)
{ {
spd_info->topo = MEM_TOPO_MEMORY_DOWN; spd_info->topo = MEM_TOPO_MEMORY_DOWN;
spd_info->cbfs_index = variant_memory_sku(); spd_info->cbfs_index = variant_memory_sku();