sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/hsw,soc/intel/{bdw,skl,apl},mb/*: unify dt panel settings

Browse Source 
There are multiple different devicetree setting formats for graphics
panel settings present in coreboot. Replace the ones for the platforms
that already have (mostly) unified gma/graphics setup code by a unified
struct in the gma driver. Hook it up in HSW, BDW, SKL, and APL and adapt
the devicetrees accordingly.

Always ensure that values don't overflow by applying appropriate masks.

The remaining platforms implementing panel settings (GM45, i945, ILK and
SNB) can be migrated later after unifying their gma/graphics setup code.

Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Change-Id: I445defe01d5fbf9a69cf05cf1b5bd6c7c2c1725e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48885
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Michael Niewöhner
2020-12-28 00:49:33 +01:00
committed by Nico Huber
parent 44fa0d4ca0
commit 97e21d3e95
32 changed files with 247 additions and 246 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/drivers/intel/gma/gma.h
View File

@@ -11,6 +11,20 @@ struct i915_gpu_controller_info {
u32 did[5];
};
/* Devicetree panel configuration */
struct i915_gpu_panel_config {
unsigned int up_delay_ms;
unsigned int down_delay_ms;
unsigned int cycle_delay_ms;
unsigned int backlight_on_delay_ms;
unsigned int backlight_off_delay_ms;
unsigned int backlight_pwm_hz;
enum {
GPU_BACKLIGHT_POLARITY_HIGH = 0,
GPU_BACKLIGHT_POLARITY_LOW,
} backlight_polarity;
};
#define GMA_STATIC_DISPLAYS(ssc) { \
.use_spread_spectrum_clock = (ssc), \
.ndid = 3, .did = { 0x0100, 0x0240, 0x0410, } \