mb/cannonlake: Remove SmbusEnable from devicetree
Remove the SmbusEnable parameter from all Cannon Lake mainboards. Instead this will be determined by the enable state of the SMBUS PCI device. Change-Id: I7ece6768da4c517747af12a07012583575816ae1 Signed-off-by: Duncan Laurie <dlaurie@google.com> Reviewed-on: https://review.coreboot.org/29551 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
		
				
					committed by
					
						
						Duncan Laurie
					
				
			
			
				
	
			
			
			
						parent
						
							6efa5c3846
						
					
				
				
					commit
					98456f4ee6
				
			@@ -20,7 +20,6 @@ chip soc/intel/cannonlake
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
	# FSP configuration
 | 
						# FSP configuration
 | 
				
			||||||
	register "SaGv" = "3"
 | 
						register "SaGv" = "3"
 | 
				
			||||||
	register "SmbusEnable" = "1"
 | 
					 | 
				
			||||||
	register "ScsEmmcHs400Enabled" = "1"
 | 
						register "ScsEmmcHs400Enabled" = "1"
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	# Intel Common SoC Config
 | 
						# Intel Common SoC Config
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -29,7 +29,6 @@ chip soc/intel/cannonlake
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
	# FSP configuration
 | 
						# FSP configuration
 | 
				
			||||||
	register "SaGv" = "SaGv_Enabled"
 | 
						register "SaGv" = "SaGv_Enabled"
 | 
				
			||||||
	register "SmbusEnable" = "1"
 | 
					 | 
				
			||||||
	register "ScsEmmcHs400Enabled" = "1"
 | 
						register "ScsEmmcHs400Enabled" = "1"
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	# Intel Common SoC Config
 | 
						# Intel Common SoC Config
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -6,7 +6,6 @@ chip soc/intel/cannonlake
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
	# FSP configuration
 | 
						# FSP configuration
 | 
				
			||||||
	register "SaGv" = "3"
 | 
						register "SaGv" = "3"
 | 
				
			||||||
	register "SmbusEnable" = "1"
 | 
					 | 
				
			||||||
	register "ScsEmmcHs400Enabled" = "1"
 | 
						register "ScsEmmcHs400Enabled" = "1"
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)"
 | 
						register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)"
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -6,7 +6,6 @@ chip soc/intel/cannonlake
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
	# FSP configuration
 | 
						# FSP configuration
 | 
				
			||||||
	register "SaGv" = "3"
 | 
						register "SaGv" = "3"
 | 
				
			||||||
	register "SmbusEnable" = "1"
 | 
					 | 
				
			||||||
	register "ScsEmmcHs400Enabled" = "1"
 | 
						register "ScsEmmcHs400Enabled" = "1"
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)"
 | 
						register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)"
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -7,7 +7,6 @@ chip soc/intel/cannonlake
 | 
				
			|||||||
	# FSP configuration
 | 
						# FSP configuration
 | 
				
			||||||
	register "SaGv" = "3"
 | 
						register "SaGv" = "3"
 | 
				
			||||||
	register "RMT" = "1"
 | 
						register "RMT" = "1"
 | 
				
			||||||
	register "SmbusEnable" = "1"
 | 
					 | 
				
			||||||
	register "ScsEmmcHs400Enabled" = "1"
 | 
						register "ScsEmmcHs400Enabled" = "1"
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC5)"
 | 
						register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC5)"
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -7,7 +7,6 @@ chip soc/intel/cannonlake
 | 
				
			|||||||
	# FSP configuration
 | 
						# FSP configuration
 | 
				
			||||||
	register "SaGv" = "3"
 | 
						register "SaGv" = "3"
 | 
				
			||||||
	register "RMT" = "1"
 | 
						register "RMT" = "1"
 | 
				
			||||||
	register "SmbusEnable" = "1"
 | 
					 | 
				
			||||||
	register "ScsEmmcHs400Enabled" = "1"
 | 
						register "ScsEmmcHs400Enabled" = "1"
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC4)"
 | 
						register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC4)"
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -6,7 +6,6 @@ chip soc/intel/cannonlake
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
	# FSP configuration
 | 
						# FSP configuration
 | 
				
			||||||
	register "SaGv" = "3"
 | 
						register "SaGv" = "3"
 | 
				
			||||||
	register "SmbusEnable" = "1"
 | 
					 | 
				
			||||||
	register "ScsEmmcHs400Enabled" = "1"
 | 
						register "ScsEmmcHs400Enabled" = "1"
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)"
 | 
						register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)"
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user