From 98f896110681c8d5f0aad88464c056bcb5b9d046 Mon Sep 17 00:00:00 2001 From: Nicholas Chin Date: Mon, 8 Jul 2024 19:14:31 -0600 Subject: [PATCH] Documentation/Makefile: Fix test target The test target called make with the `-K` flag, which is not valid. Change it to `-k` (keep going if some targets fail) which is what was probably intended. It also tried to build the `doctest` target from Makefile.sphinx, which results in an error. Further investigation reveals that this is because the sphinx doctest extension was not enabled in conf.py. However, from the documentation of doctest [1], it seems like it is intended to ensure that documentation containing Python snippets along with the expected output of the snippet remain in sync, which is something that we probably don't need. So, remove the call to it. [1] https://www.sphinx-doc.org/en/master/usage/extensions/doctest.html" Change-Id: Id514950b4486ed8644d078af222c96ed711fc8f9 Signed-off-by: Nicholas Chin Reviewed-on: https://review.coreboot.org/c/coreboot/+/83381 Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas --- Documentation/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/Makefile b/Documentation/Makefile index ec1e1a4d35..6d2a64188f 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -31,8 +31,7 @@ livesphinx: $(BUILDDIR) test: @echo "Test for logging purposes - Failing tests will not fail the build" - -$(MAKE) -f Makefile.sphinx clean && $(MAKE) -K -f Makefile.sphinx html - -$(MAKE) -f Makefile.sphinx clean && $(MAKE) -K -f Makefile.sphinx doctest + -$(MAKE) -f Makefile.sphinx clean && $(MAKE) -k -f Makefile.sphinx html help: @echo "all - Builds all documentation targets"