sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

amdfwtool: Remove the option --list which nobody uses

Browse Source 
It was used for printing the dependencies which is now taken by macro
DEP_FILES in soc/amd/common/Makefile.inc.

TEST=binary identical test on google/guybrush amd/chausie

Change-Id: I1b86df2cb2ed178cf0a263c50ccb3e2254a3852b
Signed-off-by: Zheng Bao <fishbaozi@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73627
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Zheng Bao
2023-03-09 11:43:55 +08:00
committed by Fred Reitberger
parent 4b6aa195b4
commit 994ff52464
3 changed files with 12 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
util/amdfwtool/data_parse.c
View File

@ -643,7 +643,7 @@ char get_level_from_config(char *line, regoff_t level_index, amd_cb_config *cb_c
}
static uint8_t process_one_line(char *oneline, regmatch_t *match, char *dir,
uint8_t print_deps, amd_cb_config *cb_config)
amd_cb_config *cb_config)
{
char *path_filename, *fn = &(oneline[match[2].rm_so]);
char *fw_type_str = &(oneline[match[1].rm_so]);
@ -664,13 +664,7 @@ static uint8_t process_one_line(char *oneline, regmatch_t *match, char *dir,
fw_type_str, path_filename, ch_lvl, cb_config) == 0) {
fprintf(stderr, "Module's name \"%s\" is not valid\n", fw_type_str);
return 0; /* Stop parsing. */
} else {
if (print_deps)
printf(" %s ", path_filename);
}
} else {
if (print_deps)
printf(" %s ", path_filename);
}
return 1;
}
@ -710,7 +704,7 @@ static bool is_second_gen(enum platform platform_type)
0: The config file can not be parsed correctly.
1: The config file can be parsed correctly.
*/
uint8_t process_config(FILE *config, amd_cb_config *cb_config, uint8_t print_deps)
uint8_t process_config(FILE *config, amd_cb_config *cb_config)
{
char oneline[MAX_LINE_SIZE];
regmatch_t match[N_MATCHES];
@ -776,7 +770,7 @@ uint8_t process_config(FILE *config, amd_cb_config *cb_config, uint8_t print_dep
strcmp(&(oneline[match[1].rm_so]), "SOC_NAME") == 0) {
continue;
} else {
if (process_one_line(oneline, match, dir, print_deps,
if (process_one_line(oneline, match, dir,
cb_config) == 0)
return 0;
}