sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/amd/hudson/acpi: Fix illegal object references

Browse Source 
Issue spotted using IASL 20190215 on mainboard GIZMOSPHERE_GIZMO2:
"Object is created temporarily in another method and cannot be accessed"

Change-Id: I1e4ca2c765083db3a27e415d3a69bef0912a606b
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/31554
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
Elyes HAOUAS
2019-02-21 16:38:43 +01:00
committed by Patrick Georgi
parent a213ed659a
commit 99850600d0
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/southbridge/amd/agesa/hudson/acpi/fch.asl
View File

@@ -146,6 +146,10 @@ Method(_CRS, 0) {
Return(CRES) /* note to change the Name buffer */
} /* end of Method(_SB.PCI0._CRS) */
#if IS_ENABLED(CONFIG_HUDSON_IMC_FWM)
#include "acpi/AmdImc.asl" /* Hudson IMC function */
#endif
/*
*
* FIRST METHOD CALLED UPON BOOT
@@ -172,7 +176,6 @@ Method(_INI, 0) {
OSFL()
#if IS_ENABLED(CONFIG_HUDSON_IMC_FWM)
#include "acpi/AmdImc.asl" /* Hudson IMC function */
#if IS_ENABLED(CONFIG_ACPI_ENABLE_THERMAL_ZONE)
ITZE() /* enable IMC Fan Control*/
#endif

9
src/southbridge/amd/pi/hudson/acpi/fch.asl
View File

@@ -129,6 +129,13 @@ Method(_CRS, 0) {
Return(CRES) /* note to change the Name buffer */
} /* end of Method(_SB.PCI0._CRS) */
#if IS_ENABLED(CONFIG_HUDSON_IMC_FWM)
/* TODO: It is unstable.
* might be fixed by restructuring
*/
#include "acpi/AmdImc.asl" /* Hudson IMC function */
#endif
/*
*
* FIRST METHOD CALLED UPON BOOT
@@ -155,8 +162,6 @@ Method(_INI, 0) {
OSFL()
#if IS_ENABLED(CONFIG_HUDSON_IMC_FWM)
/* TODO: It is unstable. */
#include "acpi/AmdImc.asl" /* Hudson IMC function */
#if IS_ENABLED(CONFIG_ACPI_ENABLE_THERMAL_ZONE)
ITZE() /* enable IMC Fan Control*/
#endif