sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

SuperIO LPC47N217: Remove warnings

Browse Source 
Change-Id: Id5756f1bb748ae7bec0bcdc21804f5338e850baa
Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Signed-off-by: zbao <fishbaozi@gmail.com>
Reviewed-on: http://review.coreboot.org/1402
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
zbao
2012-08-03 15:09:09 +08:00
committed by Alexandru Gagniuc
parent 15945445eb
commit 9bf356fc53
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/superio/smsc/lpc47n217/early_serial.c
View File

@@ -42,7 +42,7 @@ static void pnp_exit_conf_state(device_t dev)
* @param dev High 8 bits = Super I/O port, low 8 bits = logical device number. * @param dev High 8 bits = Super I/O port, low 8 bits = logical device number.
* @param iobase Base I/O port for the logical device. * @param iobase Base I/O port for the logical device.
*/ */
void lpc47n217_pnp_set_iobase(device_t dev, u16 iobase) static void lpc47n217_pnp_set_iobase(device_t dev, u16 iobase)
{ {
/* LPC47N217 requires base ports to be a multiple of 4. */ /* LPC47N217 requires base ports to be a multiple of 4. */
ASSERT(!(iobase & 0x3)); ASSERT(!(iobase & 0x3));
@@ -74,7 +74,7 @@ void lpc47n217_pnp_set_iobase(device_t dev, u16 iobase)
* @param dev High 8 bits = Super I/O port, low 8 bits = logical device number. * @param dev High 8 bits = Super I/O port, low 8 bits = logical device number.
* @param enable 0 to disable, anythig else to enable. * @param enable 0 to disable, anythig else to enable.
*/ */
void lpc47n217_pnp_set_enable(device_t dev, int enable) static void lpc47n217_pnp_set_enable(device_t dev, int enable)
{ {
u8 power_register = 0, power_mask = 0, current_power, new_power; u8 power_register = 0, power_mask = 0, current_power, new_power;

7
src/superio/smsc/lpc47n217/superio.c
View File

@@ -133,7 +133,8 @@ static void lpc47n217_pnp_enable(device_t dev)
*/ */
static void lpc47n217_init(device_t dev) static void lpc47n217_init(device_t dev)
{ {
struct superio_smsc_lpc47n217_config* conf = dev->chip_info; /* TODO: Reserved for future. */
/* struct superio_smsc_lpc47n217_config* conf = dev->chip_info; */
if (!dev->enabled) if (!dev->enabled)
return; return;
@@ -142,7 +143,7 @@ static void lpc47n217_init(device_t dev)
static void lpc47n217_pnp_set_resource(device_t dev, struct resource *resource) static void lpc47n217_pnp_set_resource(device_t dev, struct resource *resource)
{ {
if (!(resource->flags & IORESOURCE_ASSIGNED)) { if (!(resource->flags & IORESOURCE_ASSIGNED)) {
printk(BIOS_ERR, "ERROR: %s %02x not allocated\n", printk(BIOS_ERR, "ERROR: %s %02lx not allocated\n",
dev_path(dev), resource->index); dev_path(dev), resource->index);
return; return;
} }
@@ -160,7 +161,7 @@ static void lpc47n217_pnp_set_resource(device_t dev, struct resource *resource)
} else if (resource->flags & IORESOURCE_IRQ) { } else if (resource->flags & IORESOURCE_IRQ) {
lpc47n217_pnp_set_irq(dev, resource->base); lpc47n217_pnp_set_irq(dev, resource->base);
} else { } else {
printk(BIOS_ERR, "ERROR: %s %02x unknown resource type\n", printk(BIOS_ERR, "ERROR: %s %02lx unknown resource type\n",
dev_path(dev), resource->index); dev_path(dev), resource->index);
return; return;
} }