From 9c25a03fc350d6739398be9c121b2055e0af4b85 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 6 Feb 2024 16:43:10 +0100 Subject: [PATCH] arch/x86/mpspec: reduce scope of smp_write_ioapic smp_write_ioapic is only called from smp_write_ioapic_from_hw within the same compilation unit, so reduce its scope by making it a static function. Signed-off-by: Felix Held Change-Id: I6a1bbfd50ae9d6c8ab18f478ae9bae3f8bf5e10d Reviewed-on: https://review.coreboot.org/c/coreboot/+/80357 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/arch/x86/include/arch/smp/mpspec.h | 2 -- src/arch/x86/mpspec.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/arch/x86/include/arch/smp/mpspec.h b/src/arch/x86/include/arch/smp/mpspec.h index 48e5732a4f..0b5ca47002 100644 --- a/src/arch/x86/include/arch/smp/mpspec.h +++ b/src/arch/x86/include/arch/smp/mpspec.h @@ -225,8 +225,6 @@ void smp_write_processor(struct mp_config_table *mc, u8 cpuflag, u32 cpufeature, u32 featureflag); void smp_write_processors(struct mp_config_table *mc); -void smp_write_ioapic(struct mp_config_table *mc, - u8 id, u8 ver, void *apicaddr); /* Call smp_write_ioapic() and return IOAPIC ID field. */ u8 smp_write_ioapic_from_hw(struct mp_config_table *mc, void *apicaddr); diff --git a/src/arch/x86/mpspec.c b/src/arch/x86/mpspec.c index b8bdb09809..ac3fc79ba9 100644 --- a/src/arch/x86/mpspec.c +++ b/src/arch/x86/mpspec.c @@ -206,7 +206,7 @@ static void smp_write_bus(struct mp_config_table *mc, * Entry Type, APIC ID, Version, * APIC Flags:EN, Address */ -void smp_write_ioapic(struct mp_config_table *mc, +static void smp_write_ioapic(struct mp_config_table *mc, u8 id, u8 ver, void *apicaddr) { struct mpc_config_ioapic *mpc;