From 9d67142ccbb3421275c6aa8b44b4cbbec78054a7 Mon Sep 17 00:00:00 2001 From: Jan Samek Date: Thu, 19 Jan 2023 14:05:50 +0100 Subject: [PATCH] mb/siemens/mc_apl1: Move POST logic to mainboard level Move logic previously used only in the mc_apl2 variant to the mainboard level so that other variants can also make use of it without code duplication. This functionality on the mc_apl6 variant will be enabled in a follow-up patch. BUG=none TEST=Boot on siemens/mc_apl2 and observe that the POST codes are displayed before DRAM training. Change-Id: I762e328ad06c047d911ce1fc40f12a66cbd14e11 Signed-off-by: Jan Samek Reviewed-on: https://review.coreboot.org/c/coreboot/+/72115 Tested-by: build bot (Jenkins) Reviewed-by: Werner Zeh --- src/mainboard/siemens/mc_apl1/Makefile.inc | 2 ++ src/mainboard/siemens/mc_apl1/{variants/mc_apl2 => }/post.c | 0 src/mainboard/siemens/mc_apl1/variants/mc_apl2/Makefile.inc | 2 -- 3 files changed, 2 insertions(+), 2 deletions(-) rename src/mainboard/siemens/mc_apl1/{variants/mc_apl2 => }/post.c (100%) diff --git a/src/mainboard/siemens/mc_apl1/Makefile.inc b/src/mainboard/siemens/mc_apl1/Makefile.inc index fa7aea9049..124e3806ff 100644 --- a/src/mainboard/siemens/mc_apl1/Makefile.inc +++ b/src/mainboard/siemens/mc_apl1/Makefile.inc @@ -7,6 +7,8 @@ romstage-y += romstage.c ramstage-y += mainboard.c +all-$(CONFIG_NC_FPGA_POST_CODE) += post.c + subdirs-y += variants/baseboard CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/post.c b/src/mainboard/siemens/mc_apl1/post.c similarity index 100% rename from src/mainboard/siemens/mc_apl1/variants/mc_apl2/post.c rename to src/mainboard/siemens/mc_apl1/post.c diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/Makefile.inc b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/Makefile.inc index 9ec2c8024f..152b46ece1 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/Makefile.inc +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/Makefile.inc @@ -2,5 +2,3 @@ bootblock-y += gpio.c ramstage-y += gpio.c ramstage-y += mainboard.c - -all-$(CONFIG_NC_FPGA_POST_CODE) += post.c