sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/i2c/lenovo_serials: Use buildtime constants

Browse Source 
The coreboot_version global variable just gets filled with the
COREBOOT_VERSION macro so there is no reason to use a runtime strconcat.

Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Change-Id: I3a2be7293d07ac591855ebd784bba350cdffa70f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78945
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Arthur Heymans
2023-11-07 11:00:21 +01:00
committed by Felix Held
parent 0fd61e67a0
commit 9eb0b19861
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/drivers/i2c/at24rf08c/Makefile.inc
View File

@@ -1,4 +1,5 @@
## SPDX-License-Identifier: GPL-2.0-only ## SPDX-License-Identifier: GPL-2.0-only
ramstage-$(CONFIG_DRIVER_LENOVO_SERIALS) += at24rf08c.c ramstage-$(CONFIG_DRIVER_LENOVO_SERIALS) += at24rf08c.c
$(call src-to-obj,ramstage,$(dir)/lenovo_serials.c) : $(obj)/build.h
ramstage-$(CONFIG_DRIVER_LENOVO_SERIALS) += lenovo_serials.c ramstage-$(CONFIG_DRIVER_LENOVO_SERIALS) += lenovo_serials.c

8
src/drivers/i2c/at24rf08c/lenovo_serials.c
View File

@@ -1,5 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
#include <build.h>
#include <types.h> #include <types.h>
#include <string.h> #include <string.h>
#include <device/device.h> #include <device/device.h>
@@ -183,16 +184,11 @@ const char *smbios_mainboard_version(void)
const char *smbios_mainboard_bios_version(void) const char *smbios_mainboard_bios_version(void)
{ {
static char *s = NULL;
/* Satisfy thinkpad_acpi. */ /* Satisfy thinkpad_acpi. */
if (strlen(CONFIG_LOCALVERSION)) if (strlen(CONFIG_LOCALVERSION))
return "CBET4000 " CONFIG_LOCALVERSION; return "CBET4000 " CONFIG_LOCALVERSION;
if (s != NULL) return "CBET4000 " COREBOOT_VERSION;
return s;
s = strconcat("CBET4000 ", coreboot_version);
return s;
} }
const char *smbios_mainboard_manufacturer(void) const char *smbios_mainboard_manufacturer(void)