sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/amd: Remove dead assignment in SPI driver

Browse Source 
Value stored to 'cmd' is never read

Change-Id: I794b6e12f5af272705cd996f7ca5099e9b9dbfc7
Found-by: scan-build from clang 6
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/29568
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Paul Menzel
2018-11-10 11:27:02 +01:00
committed by Patrick Georgi
parent dee0f8845b
commit 9eb4d0a069
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/southbridge/amd/agesa/hudson/spi.c
View File

@ -132,7 +132,7 @@ static int spi_ctrlr_xfer(const struct spi_slave *slave, const void *dout,
reset_internal_fifo_pointer();
/* Skip the bytes we sent. */
for (count = 0; count < bytesout; count++) {
cmd = spi_read(SPI_REG_FIFO);
spi_read(SPI_REG_FIFO);
}
for (count = 0; count < bytesin; count++, din++) {

2
src/southbridge/amd/cimx/sb800/spi.c
View File

@ -95,7 +95,7 @@ static int spi_ctrlr_xfer(const struct spi_slave *slave, const void *dout,
reset_internal_fifo_pointer();
/* Skip the bytes we sent. */
for (count = 0; count < bytesout; count++) {
cmd = read8((void *)(spibar + 0x0C));
read8((void *)(spibar + 0x0C));
}
reset_internal_fifo_pointer();