cpu/x86/lapic: Move LAPIC configuration to MP init

Implementation for setup_lapic() did two things -- call
enable_lapic() and virtual_wire_mode_init().

In PARALLEL_MP case enable_lapic() was redundant as it
was already executed prior to initialize_cpu() call.
For the !PARALLEL_MP case enable_lapic() is added to
AP CPUs.

Change-Id: I5caf94315776a499e9cf8f007251b61f51292dc5
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58387
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Kyösti Mälkki
2021-10-17 08:34:31 +03:00
parent 7261b5ade5
commit 9ec7227c9b
42 changed files with 12 additions and 143 deletions

View File

@@ -185,6 +185,7 @@ static void asmlinkage ap_init(void)
/* Ensure the local APIC is enabled */
enable_lapic();
setup_lapic_interrupts();
info->cpu = cpus_dev[info->index];
@@ -543,6 +544,7 @@ static void init_bsp(struct bus *cpu_bus)
/* Ensure the local APIC is enabled */
enable_lapic();
setup_lapic_interrupts();
/* Set the device path of the boot CPU. */
cpu_path.type = DEVICE_PATH_APIC;