sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/cbfstool/eventlog: Use LocalTime or UTC timestamps

Browse Source 
Add a new flag "--utc" to allow the user to choose if
elogtool should print timestamps in Local Time or in UTC.
It is useful for generating automated crash reports
including all system logs when users are located in
various regions (timezones).

Add information about timezone to timestamps printed
on the console.

Signed-off-by: Wojciech Macek <wmacek@google.com>
Change-Id: I30ba0e17c67ab4078e3a7137ece69009a63d68fa
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73201
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jakub Czapiga <jacz@semihalf.com>
This commit is contained in:
Wojciech Macek
2023-02-23 09:33:06 +01:00
committed by Felix Held
parent fd8664e178
commit 9edaccd922
3 changed files with 44 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
util/cbfstool/eventlog.c
View File

@@ -49,10 +49,12 @@ static void eventlog_printf(const char *format, ...)
*
* Forms the key-value description pair for the event timestamp.
*/
static void eventlog_print_timestamp(const struct event_header *event)
static void eventlog_print_timestamp(const struct event_header *event,
enum eventlog_timezone tz)
{
const char *tm_format = "%y-%m-%d%t%H:%M:%S";
char tm_string[40];
struct tm *tmptr;
struct tm tm;
time_t time;
@@ -78,7 +80,11 @@ static void eventlog_print_timestamp(const struct event_header *event)
time = mktime(&tm);
time += tm.tm_gmtoff; /* force adjust for timezone */
strftime(tm_string, sizeof(tm_string), "%Y-%m-%d %H:%M:%S", localtime(&time));
if (tz == EVENTLOG_TIMEZONE_UTC)
tmptr = gmtime(&time);
else
tmptr = localtime(&time);
strftime(tm_string, sizeof(tm_string), "%Y-%m-%d %H:%M:%S%z", tmptr);
eventlog_printf("%s", tm_string);
}
@@ -648,13 +654,14 @@ static int eventlog_print_data(const struct event_header *event)
return 0;
}
void eventlog_print_event(const struct event_header *event, int count)
void eventlog_print_event(const struct event_header *event, int count,
enum eventlog_timezone tz)
{
/* Ignore the printf separator at the beginning and end of each line */
eventlog_printf_ignore_separator_once = 1;
eventlog_printf("%d", count);
eventlog_print_timestamp(event);
eventlog_print_timestamp(event, tz);
eventlog_print_type(event);
eventlog_print_data(event);