From 9f9bfdd5a1a314633d8ac154ed2d2b5b90653865 Mon Sep 17 00:00:00 2001 From: Jonathan Zhang Date: Fri, 21 Oct 2022 18:07:41 -0700 Subject: [PATCH] drivers/ipmi/ipmi_kcs_ops.c: accommodate BMC revision being 0 BMC major/minor revision may be 0. Get the value directly from BMC without checking to accommodate such situation. Signed-off-by: Tim Chu Signed-off-by: Jonathan Zhang Change-Id: I0e08c6d02de8f6efceb69b6d6cebad9d61cfd20e Reviewed-on: https://review.coreboot.org/c/coreboot/+/68685 Reviewed-by: Shuming Chu (Shuming) Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/drivers/ipmi/ipmi_kcs_ops.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/drivers/ipmi/ipmi_kcs_ops.c b/src/drivers/ipmi/ipmi_kcs_ops.c index a2ad7abd86..28ced49f53 100644 --- a/src/drivers/ipmi/ipmi_kcs_ops.c +++ b/src/drivers/ipmi/ipmi_kcs_ops.c @@ -259,14 +259,8 @@ static void ipmi_ssdt(const struct device *dev) void ipmi_bmc_version(uint8_t *ipmi_bmc_major_revision, uint8_t *ipmi_bmc_minor_revision) { - if (!bmc_revision_major || !bmc_revision_minor) { - printk(BIOS_ERR, "IPMI: BMC revision missing\n"); - *ipmi_bmc_major_revision = 0; - *ipmi_bmc_minor_revision = 0; - } else { - *ipmi_bmc_major_revision = bmc_revision_major; - *ipmi_bmc_minor_revision = bmc_revision_minor; - } + *ipmi_bmc_major_revision = bmc_revision_major; + *ipmi_bmc_minor_revision = bmc_revision_minor; } #if CONFIG(GENERATE_SMBIOS_TABLES)