sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/abuild: Add more error handling for command line options

Browse Source 
- Show an error if a directory is added after the command line options
to catch scripts using the old parameters.
- If an invalid parameter is specified, show the parameter.

Change-Id: Ie8948361f1c51e89a99bdb13df8c554747cd521d
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/17741
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Martin Roth 2016-12-06 09:51:54 -07:00
parent 5b0d2dbdce
commit 9fdb41ab9a
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
util/abuild/abuild
View File

@ -676,10 +676,13 @@ while true ; do
configoptions="$(cat "$1")${configoptions}\n" configoptions="$(cat "$1")${configoptions}\n"
shift;; shift;;
--) shift; break;; --) shift; break;;
-*) printf "Invalid option\n\n"; myhelp; exit 1;; -*) printf "Invalid option '%s'\n\n" "$1"; myhelp; exit 1;;
*) break;; *) break;;
esac esac
done done
if [ -n "$1" ]; then
printf "Invalid option '%s'\n\n" "$1"; myhelp; exit 1;
fi
if [ -z "$TARGET" ] || [ "$TARGET" = "/" ]; then if [ -z "$TARGET" ] || [ "$TARGET" = "/" ]; then
echo "Please specify a valid, non-root build directory." echo "Please specify a valid, non-root build directory."