From a01838681eeccc7b3453b6d30b658b36def775a3 Mon Sep 17 00:00:00 2001 From: Tim Crawford Date: Wed, 17 May 2023 12:23:56 -0600 Subject: [PATCH] mb/system76: Remove PL4 values System76 EC sets PL4 values through PECI based on AC state [1]. Remove the static PL4 values from coreboot since they won't be used. This will result in sysfs reporting the package default for PL4. [1]: https://github.com/system76/ec/pull/353 Change-Id: If33eb38a20febaf8c71615f0d1a640d3991f42ff Signed-off-by: Tim Crawford --- src/mainboard/system76/adl/variants/darp8/overridetree.cb | 3 --- src/mainboard/system76/adl/variants/galp6/overridetree.cb | 1 - src/mainboard/system76/adl/variants/lemp11/overridetree.cb | 1 - src/mainboard/system76/adl/variants/oryp10/overridetree.cb | 2 -- src/mainboard/system76/adl/variants/oryp9/overridetree.cb | 2 -- src/mainboard/system76/rpl/variants/galp7/overridetree.cb | 1 - src/mainboard/system76/rpl/variants/lemp12/overridetree.cb | 1 - 7 files changed, 11 deletions(-) diff --git a/src/mainboard/system76/adl/variants/darp8/overridetree.cb b/src/mainboard/system76/adl/variants/darp8/overridetree.cb index 5f82c443c0..9180e91759 100644 --- a/src/mainboard/system76/adl/variants/darp8/overridetree.cb +++ b/src/mainboard/system76/adl/variants/darp8/overridetree.cb @@ -1,10 +1,7 @@ chip soc/intel/alderlake - # HACK: Limit PL4 to PL2 to prevent power-off when system is booted on - # battery power. This seems to only happen with the i7 units. register "power_limits_config[ADL_P_282_482_28W_CORE]" = "{ .tdp_pl1_override = 20, .tdp_pl2_override = 56, - .tdp_pl4 = 56, // FIXME: Set to 65 }" # GPE configuration diff --git a/src/mainboard/system76/adl/variants/galp6/overridetree.cb b/src/mainboard/system76/adl/variants/galp6/overridetree.cb index c10e17adbc..d770bcdcb5 100644 --- a/src/mainboard/system76/adl/variants/galp6/overridetree.cb +++ b/src/mainboard/system76/adl/variants/galp6/overridetree.cb @@ -2,7 +2,6 @@ chip soc/intel/alderlake register "power_limits_config[ADL_P_282_482_28W_CORE]" = "{ .tdp_pl1_override = 28, .tdp_pl2_override = 60, - .tdp_pl4 = 90, }" # GPE configuration diff --git a/src/mainboard/system76/adl/variants/lemp11/overridetree.cb b/src/mainboard/system76/adl/variants/lemp11/overridetree.cb index 82943cbce1..379dad8bb3 100644 --- a/src/mainboard/system76/adl/variants/lemp11/overridetree.cb +++ b/src/mainboard/system76/adl/variants/lemp11/overridetree.cb @@ -2,7 +2,6 @@ chip soc/intel/alderlake register "power_limits_config[ADL_P_142_242_282_15W_CORE]" = "{ .tdp_pl1_override = 15, .tdp_pl2_override = 46, - .tdp_pl4 = 65, }" # GPE configuration diff --git a/src/mainboard/system76/adl/variants/oryp10/overridetree.cb b/src/mainboard/system76/adl/variants/oryp10/overridetree.cb index f9ceb120fa..44e388be90 100644 --- a/src/mainboard/system76/adl/variants/oryp10/overridetree.cb +++ b/src/mainboard/system76/adl/variants/oryp10/overridetree.cb @@ -1,10 +1,8 @@ chip soc/intel/alderlake - # HACK: Limit PL4 to prevent power off on battery power. register "power_limits_config[ADL_P_642_682_45W_CORE]" = "{ .tdp_pl1_override = 45, .tdp_pl2_override = 115, .tdp_psyspl2 = 135, - .tdp_pl4 = 72, }" # Thermal diff --git a/src/mainboard/system76/adl/variants/oryp9/overridetree.cb b/src/mainboard/system76/adl/variants/oryp9/overridetree.cb index 519d173ac0..c88a105984 100644 --- a/src/mainboard/system76/adl/variants/oryp9/overridetree.cb +++ b/src/mainboard/system76/adl/variants/oryp9/overridetree.cb @@ -1,10 +1,8 @@ chip soc/intel/alderlake - # HACK: Limit PL4 to prevent power off on battery power. register "power_limits_config[ADL_P_642_682_45W_CORE]" = "{ .tdp_pl1_override = 45, .tdp_pl2_override = 115, .tdp_psyspl2 = 135, - .tdp_pl4 = 72, }" # Thermal diff --git a/src/mainboard/system76/rpl/variants/galp7/overridetree.cb b/src/mainboard/system76/rpl/variants/galp7/overridetree.cb index ee538fc2a7..c868054a62 100644 --- a/src/mainboard/system76/rpl/variants/galp7/overridetree.cb +++ b/src/mainboard/system76/rpl/variants/galp7/overridetree.cb @@ -2,7 +2,6 @@ chip soc/intel/alderlake register "power_limits_config[RPL_P_682_642_482_45W_CORE]" = "{ .tdp_pl1_override = 45, .tdp_pl2_override = 78, - .tdp_pl4 = 90, }" device domain 0 on diff --git a/src/mainboard/system76/rpl/variants/lemp12/overridetree.cb b/src/mainboard/system76/rpl/variants/lemp12/overridetree.cb index d2eb6f4792..6f6ede508a 100644 --- a/src/mainboard/system76/rpl/variants/lemp12/overridetree.cb +++ b/src/mainboard/system76/rpl/variants/lemp12/overridetree.cb @@ -2,7 +2,6 @@ chip soc/intel/alderlake register "power_limits_config[RPL_P_282_242_142_15W_CORE]" = "{ .tdp_pl1_override = 15, .tdp_pl2_override = 46, - .tdp_pl4 = 65, }" device domain 0 on