sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gfx: Move drivers/generic/gfx to drivers/gfx/generic

Browse Source 
This change creates gfx directory under drivers/ so that all drivers
handling gfx devices can be located in the same place. In follow-up
CLs, we will be adding another driver that handles gfx devices.

This change also updates the names used within the driver from
*generic_gfx* to *gfx_generic*. In addition to that, mainboard
drallion using this driver is updated to match the correct path and
Kconfig name.

TEST=Verified that drallion still builds.

Change-Id: I377743e0f6d770eed143c7b6041dab2a101e6252
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39047
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Mathew King <mathewk@chromium.org>
This commit is contained in:
Furquan Shaikh
2020-02-21 09:57:54 -08:00
committed by Patrick Georgi
parent 4684dc0c63
commit a0b0d42d69
7 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/drivers/generic/gfx/Kconfig
View File

@@ -1,6 +0,0 @@
config DRIVERS_GENERIC_GFX
bool
default n
depends on HAVE_ACPI_TABLES
help
Include support for generic graphics device in devicetree

1
src/drivers/generic/gfx/Makefile.inc
View File

@@ -1 +0,0 @@
ramstage-$(CONFIG_DRIVERS_GENERIC_GFX) += gfx.c

56
src/drivers/generic/gfx/chip.h
View File

@@ -1,56 +0,0 @@
/*
* This file is part of the coreboot project.
*
* Copyright 2019 Google LLC
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
#ifndef __DRIVERS_GENERIC_GFX_CHIP_H__
#define __DRIVERS_GENERIC_GFX_CHIP_H__
/* Config for electronic privacy screen */
struct drivers_generic_gfx_privacy_screen_config {
/* Is privacy screen available on this graphics device */
int enabled;
/* ACPI namespace path to privacy screen detection function */
const char *detect_function;
/* ACPI namespace path to privacy screen status function */
const char *status_function;
/* ACPI namespace path to privacy screen enable function */
const char *enable_function;
/* ACPI namespace path to privacy screen disable function */
const char *disable_function;
};
/* Config for an output device as defined in section A.5 of the ACPI spec */
struct drivers_generic_gfx_device_config {
/* ACPI device name of the output device */
const char *name;
/* The address of the output device. See section A.3.2 */
unsigned int addr;
/* Electronic privacy screen specific config */
struct drivers_generic_gfx_privacy_screen_config privacy;
};
/* Config for an ACPI video device defined in Appendix A of the ACPI spec */
struct drivers_generic_gfx_config {
/*
* ACPI device name of the graphics card, "GFX0" will be used if name is
* not set
*/
const char *name;
/* The number of output devices defined */
int device_count;
/* Config for output devices */
struct drivers_generic_gfx_device_config device[5];
};
#endif /* __DRIVERS_GENERIC_GFX_CHIP_H__ */

129
src/drivers/generic/gfx/gfx.c
View File

@@ -1,129 +0,0 @@
/*
* This file is part of the coreboot project.
*
* Copyright 2019 Google LLC
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
#include <arch/acpigen.h>
#include <console/console.h>
#include <device/device.h>
#include <device/pci.h>
#include <device/pci_ids.h>
#include <stdint.h>
#include "chip.h"
#define ACPI_DSM_PRIVACY_SCREEN_UUID "C7033113-8720-4CEB-9090-9D52B3E52D73"
static void privacy_screen_detect_cb(void *arg)
{
struct drivers_generic_gfx_privacy_screen_config *config = arg;
acpigen_write_store();
acpigen_emit_namestring(config->detect_function);
acpigen_emit_byte(LOCAL2_OP);
acpigen_write_if_lequal_op_int(LOCAL2_OP, 1);
acpigen_write_return_singleton_buffer(0xF);
acpigen_pop_len();
}
static void privacy_screen_get_status_cb(void *arg)
{
struct drivers_generic_gfx_privacy_screen_config *config = arg;
acpigen_emit_byte(RETURN_OP);
acpigen_emit_namestring(config->status_function);
}
static void privacy_screen_enable_cb(void *arg)
{
struct drivers_generic_gfx_privacy_screen_config *config = arg;
acpigen_emit_namestring(config->enable_function);
}
static void privacy_screen_disable_cb(void *arg)
{
struct drivers_generic_gfx_privacy_screen_config *config = arg;
acpigen_emit_namestring(config->disable_function);
}
static void (*privacy_screen_callbacks[])(void *) = {
privacy_screen_detect_cb,
privacy_screen_get_status_cb,
privacy_screen_enable_cb,
privacy_screen_disable_cb,
};
static void gfx_fill_ssdt_generator(struct device *dev)
{
size_t i;
struct drivers_generic_gfx_config *config = dev->chip_info;
const char *scope = acpi_device_scope(dev);
if (!scope)
return;
acpigen_write_scope(scope);
/* Method (_DOD, 0) */
acpigen_write_method("_DOD", 0);
acpigen_emit_byte(RETURN_OP);
acpigen_write_package(config->device_count);
for (i = 0; i < config->device_count; i++)
acpigen_write_dword(config->device[i].addr);
acpigen_pop_len(); /* End Package. */
acpigen_pop_len(); /* End Method. */
for (i = 0; i < config->device_count; i++) {
acpigen_write_device(config->device[i].name);
acpigen_write_name_integer("_ADR", config->device[i].addr);
acpigen_write_name_integer("_STA", 0xF);
if (config->device[i].privacy.enabled) {
acpigen_write_dsm(ACPI_DSM_PRIVACY_SCREEN_UUID,
privacy_screen_callbacks,
ARRAY_SIZE(privacy_screen_callbacks),
&config->device[i].privacy);
}
acpigen_pop_len(); /* Device */
}
acpigen_pop_len(); /* Scope */
}
static const char *gfx_acpi_name(const struct device *dev)
{
struct drivers_generic_gfx_config *config = dev->chip_info;
return config->name ? : "GFX0";
}
static struct device_operations gfx_ops = {
.acpi_name = gfx_acpi_name,
.acpi_fill_ssdt_generator = gfx_fill_ssdt_generator,
};
static void gfx_enable(struct device *dev)
{
struct drivers_generic_gfx_config *config = dev->chip_info;
if (!config)
return;
dev->ops = &gfx_ops;
}
struct chip_operations drivers_generic_gfx_ops = {
CHIP_NAME("Graphics Device")
.enable_dev = gfx_enable
};