sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/xeon_sp: Rewrite acpi_create_satc

Browse Source 
SATC is for RCiEPs (Root Complex Integrated EndPoints) but not
limited to IOAT domains. Rewrite the func by iterating all domains
and its RCiEPs. Currently the codes only support 1 PCIe segment.

TEST=intel/archercity CRB

coreboot SATC generation logs are unchanged before and after.

Change-Id: I1dfc56ccf279b77cfab4ae3457aa8799d2d57a34
Signed-off-by: Shuo Liu <shuo.liu@intel.com>
Signed-off-by: Jincheng Li <jincheng.li@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81049
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Shuo Liu
2024-03-06 00:24:02 +08:00
committed by Lean Sheng Tan
parent a454b62937
commit a0b7c06d07
1 changed files with 16 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/soc/intel/xeon_sp/uncore_acpi.c
View File

@@ -493,12 +493,12 @@ static unsigned long acpi_create_rhsa(unsigned long current)
return current;
}
static unsigned long xeonsp_create_satc_ioat(unsigned long current, const STACK_RES *ri)
static unsigned long xeonsp_create_satc(unsigned long current, struct device *domain)
{
for (int b = ri->BusBase; b <= ri->BusLimit; ++b) {
struct device *dev = pcidev_path_on_bus(b, PCI_DEVFN(0, 0));
while (dev) {
struct device *dev = NULL;
while ((dev = dev_bus_each_child(domain->downstream, dev))) {
if (pciexp_find_extended_cap(dev, PCIE_EXT_CAP_ID_ATS, 0)) {
const uint32_t b = domain->downstream->secondary;
const uint32_t d = PCI_SLOT(dev->path.pci.devfn);
const uint32_t f = PCI_FUNC(dev->path.pci.devfn);
printk(BIOS_DEBUG, " [SATC Endpoint Device] "
@@ -506,31 +506,21 @@ static unsigned long xeonsp_create_satc_ioat(unsigned long current, const STACK_
" PCI Path: 0x%x, 0x%x\n", 0, b, d, f);
current += acpi_create_dmar_ds_pci(current, b, d, f);
}
dev = dev->sibling;
}
}
return current;
}
/* SoC Integrated Address Translation Cache */
static unsigned long acpi_create_satc(unsigned long current, const IIO_UDS *hob)
static unsigned long acpi_create_satc(unsigned long current)
{
const unsigned long tmp = current;
// Add the SATC header
current += acpi_create_dmar_satc(current, 0, 0);
// Find the IOAT devices on each socket
for (int socket = CONFIG_MAX_SOCKET - 1; socket >= 0; --socket) {
if (!soc_cpu_is_enabled(socket))
continue;
for (int stack = (MAX_LOGIC_IIO_STACK - 1); stack >= 0; --stack) {
const STACK_RES *ri = &hob->PlatformData.IIO_resource[socket].StackRes[stack];
// Add the IOAT ATS devices to the SATC
if (CONFIG(HAVE_IOAT_DOMAINS) && is_ioat_iio_stack_res(ri))
current = xeonsp_create_satc_ioat(current, ri);
}
}
struct device *dev = NULL;
while ((dev = dev_find_path(dev, DEVICE_PATH_DOMAIN)))
current = xeonsp_create_satc(current, dev);
acpi_dmar_satc_fixup(tmp, current);
return current;
@@ -558,8 +548,7 @@ static unsigned long acpi_fill_dmar(unsigned long current)
current = acpi_create_rhsa(current);
// SATC
if (CONFIG(HAVE_IOAT_DOMAINS))
current = acpi_create_satc(current, hob);
current = acpi_create_satc(current);
return current;
}