sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove guarding #includes by CONFIG_FOO combinations

Browse Source 
First of many to remove guarding the inclusion of headers based on
CONFIG_ options. This *potentially* could hide issues such as functions
being swapped from under our feet, since different runtime behaviour
could be declared with the function same name and type-signature. Hence,
depending on the header we happen to get may change runtime behaviour.

Change-Id: Ife56801c783c44e1882abef711e09b85b7f295a4
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/6055
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
This commit is contained in:
Edward O'Callaghan
2014-06-17 17:05:36 +10:00
committed by Patrick Georgi
parent 9107e53756
commit a173a6255b
7 changed files with 2 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/device/oprom/yabel/interrupt.c
View File

@@ -24,10 +24,8 @@
#include <x86emu/x86emu.h>
#include "../x86emu/prim_ops.h"
#if CONFIG_PCI_OPTION_ROM_RUN_YABEL
#include <device/pci.h>
#include <device/pci_ops.h>
#endif
//setup to run the code at the address, that the Interrupt Vector points to...