sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Unify ID_SECTION_OFFSET and mark it deprecated

Browse Source 
We used to put the id section at -0x10, with some boards overriding
this to avoid collisions with romstraps.
Hardcode the location at -0x80, at the possible expense of some space
(0x70 bytes).
This also makes the section easier to find in a binary image.

At some point, CONFIG_ID_SECTION_OFFSET can be removed, so this option
is moved to src/Kconfig.deprecated_options.

Change-Id: I6ce2d6e94e57717939bda070bfe0c9df80ca2a89
Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>
Reviewed-on: http://review.coreboot.org/549
Tested-by: build bot (Jenkins)
Reviewed-by: Peter Stuge <peter@stuge.se>
This commit is contained in:
Patrick Georgi
2012-01-18 09:43:52 +01:00
committed by Peter Stuge
parent 3ad8c54c01
commit a31bb0779a
8 changed files with 4 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Kconfig
View File

@@ -883,10 +883,6 @@ config WARNINGS_ARE_ERRORS
bool bool
default y default y
config ID_SECTION_OFFSET
hex
default 0x10
# The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE, # The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE,
# POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are # POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are
# mutually exclusive. One of these options must be selected in the # mutually exclusive. One of these options must be selected in the

4
src/Kconfig.deprecated_options
View File

@@ -61,4 +61,8 @@ config PCIE_TUNING
This variable enables certain PCIe optimizations. Right now it's This variable enables certain PCIe optimizations. Right now it's
only ASPM and it's untested. only ASPM and it's untested.
config ID_SECTION_OFFSET
hex
default 0x80
endmenu endmenu

4
src/mainboard/amd/serengeti_cheetah_fam10/Kconfig
View File

@@ -87,8 +87,4 @@ config RAMBASE
hex hex
default 0x200000 default 0x200000
config ID_SECTION_OFFSET
hex
default 0x80
endif # BOARD_AMD_SERENGETI_CHEETAH_FAM10 endif # BOARD_AMD_SERENGETI_CHEETAH_FAM10

4
src/mainboard/msi/ms9652_fam10/Kconfig
View File

@@ -170,10 +170,6 @@ config AMD_UCODE_PATCH_FILE
string string
default "mc_patch_01000096.h" default "mc_patch_01000096.h"
config ID_SECTION_OFFSET
hex
default 0x80
config HT3_SUPPORT config HT3_SUPPORT
bool bool
default y default y

4
src/southbridge/nvidia/ck804/Kconfig
View File

@@ -10,10 +10,6 @@ config BOOTBLOCK_SOUTHBRIDGE_INIT
string string
default "southbridge/nvidia/ck804/bootblock.c" default "southbridge/nvidia/ck804/bootblock.c"
config ID_SECTION_OFFSET
hex
default 0x80
config EHCI_BAR config EHCI_BAR
hex hex
default 0xfef00000 default 0xfef00000

4
src/southbridge/nvidia/mcp55/Kconfig
View File

@@ -9,10 +9,6 @@ config BOOTBLOCK_SOUTHBRIDGE_INIT
string string
default "southbridge/nvidia/mcp55/bootblock.c" default "southbridge/nvidia/mcp55/bootblock.c"
config ID_SECTION_OFFSET
hex
default 0x80
config EHCI_BAR config EHCI_BAR
hex hex
default 0xfef00000 default 0xfef00000

4
src/southbridge/sis/sis966/Kconfig
View File

@@ -7,10 +7,6 @@ config BOOTBLOCK_SOUTHBRIDGE_INIT
string string
default "southbridge/sis/sis966/bootblock.c" if SOUTHBRIDGE_SIS_SIS966 default "southbridge/sis/sis966/bootblock.c" if SOUTHBRIDGE_SIS_SIS966
config ID_SECTION_OFFSET
hex
default 0x80 if SOUTHBRIDGE_SIS_SIS966
config EHCI_BAR config EHCI_BAR
hex hex
default 0xfef00000 if SOUTHBRIDGE_SIS_SIS966 default 0xfef00000 if SOUTHBRIDGE_SIS_SIS966

4
src/southbridge/via/k8t890/Kconfig
View File

@@ -50,7 +50,3 @@ config VIDEO_MB
default -1 if K8M890_VIDEO_MB_CMOS default -1 if K8M890_VIDEO_MB_CMOS
depends on SOUTHBRIDGE_VIA_K8M890_VGA_EN depends on SOUTHBRIDGE_VIA_K8M890_VGA_EN
config ID_SECTION_OFFSET
hex
default 0x80 if SOUTHBRIDGE_VIA_K8M800 || SOUTHBRIDGE_VIA_K8T800_OLD || SOUTHBRIDGE_VIA_K8T800 || SOUTHBRIDGE_VIA_K8T800PRO || SOUTHBRIDGE_VIA_K8M890 || SOUTHBRIDGE_VIA_K8T890