sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AMD Fam10h: Only create _PR scope if it is filled in

Browse Source 
The former pstates_algorithm() function has two early exit
points now, and so it might never get around to writing
pstates data.

Change-Id: I19ca937375c6d33b78bd5b1859fa5c25473be9b6
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/8610
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
Patrick Georgi
2015-03-05 20:18:21 +01:00
committed by Patrick Georgi
parent e236204d53
commit a425b96091
2 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/cpu/amd/model_10xxx/fidvid.c
View File

@@ -79,7 +79,7 @@ Fam10 Bios and Kernel Development Guide #31116, rev 3.48, April 22, 2010
11.- finalPstateChange() from init_fidvid_Stage2 (BKDG says just "may", anyway) 11.- finalPstateChange() from init_fidvid_Stage2 (BKDG says just "may", anyway)
12.- generate ACPI for p-states. 12.- generate ACPI for p-states.
generated in powernow_acpi.c pstates_algorithm() generated in powernow_acpi.c amd_generate_powernow()
"must also be completed" "must also be completed"

13
src/cpu/amd/model_10xxx/powernow_acpi.c
View File

@@ -79,7 +79,7 @@ static void write_pstates_for_core(u8 pstate_num, u16 *pstate_feq, u32 *pstate_p
* processor combination is installed. If it does break please fix the * processor combination is installed. If it does break please fix the
* code in the proper locations! * code in the proper locations!
*/ */
static void pstates_algorithm(u32 pcontrol_blk, u8 plen, u8 onlyBSP) void amd_generate_powernow(u32 pcontrol_blk, u8 plen, u8 onlyBSP)
{ {
u8 processor_brand[49]; u8 processor_brand[49];
u32 *v; u32 *v;
@@ -260,17 +260,12 @@ static void pstates_algorithm(u32 pcontrol_blk, u8 plen, u8 onlyBSP)
Pstate_latency[index]); Pstate_latency[index]);
} }
char pscope[] = "\\_PR";
acpigen_write_scope(pscope);
for (index = 0; index < cmp_cap; index++) for (index = 0; index < cmp_cap; index++)
write_pstates_for_core(Pstate_num, Pstate_feq, Pstate_power, write_pstates_for_core(Pstate_num, Pstate_feq, Pstate_power,
Pstate_latency, Pstate_control, Pstate_status, Pstate_latency, Pstate_control, Pstate_status,
index, pcontrol_blk, plen, onlyBSP); index, pcontrol_blk, plen, onlyBSP);
}
void amd_generate_powernow(u32 pcontrol_blk, u8 plen, u8 onlyBSP)
{
char pscope[] = "\\_PR";
acpigen_write_scope(pscope);
pstates_algorithm(pcontrol_blk, plen, onlyBSP);
acpigen_pop_len(); acpigen_pop_len();
} }