Drop unnecessary DEVICE_NOOP entries

Providing an explicit no-op function pointer is only necessary for
`.read_resources` and `.set_resources`. All other device-operation
pointers are optional and can be NULL.

Change-Id: I3d139f7be86180558cabec04b8566873062e33be
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40206
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nico Huber
2020-04-05 13:55:12 +02:00
parent 9734325f45
commit a461b694a6
77 changed files with 1 additions and 92 deletions

View File

@@ -57,7 +57,6 @@ static const char *adau7002_acpi_name(const struct device *dev)
static struct device_operations adau7002_ops = {
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
#if CONFIG(HAVE_ACPI_TABLES)
.acpi_name = adau7002_acpi_name,
.acpi_fill_ssdt = adau7002_fill_ssdt,

View File

@@ -70,7 +70,6 @@ static const char *generic_dev_acpi_name(const struct device *dev)
static struct device_operations generic_dev_ops = {
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.acpi_name = generic_dev_acpi_name,
.acpi_fill_ssdt = generic_dev_fill_ssdt_generator,
};

View File

@@ -104,7 +104,6 @@ static const char *gpio_keys_acpi_name(const struct device *dev)
static struct device_operations gpio_keys_ops = {
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.acpi_name = gpio_keys_acpi_name,
.acpi_fill_ssdt = gpio_keys_fill_ssdt_generator,
};

View File

@@ -61,7 +61,6 @@ static const char *gpio_regulator_acpi_name(const struct device *dev)
static struct device_operations gpio_regulator_ops = {
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.acpi_name = gpio_regulator_acpi_name,
.acpi_fill_ssdt = gpio_regulator_fill_ssdt_generator,
};

View File

@@ -96,7 +96,6 @@ static void ioapic_read_resources(struct device *dev)
static struct device_operations ioapic_operations = {
.read_resources = ioapic_read_resources,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = ioapic_init,
};

View File

@@ -72,7 +72,6 @@ static const char *max98357a_acpi_name(const struct device *dev)
static struct device_operations max98357a_ops = {
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
#if CONFIG(HAVE_ACPI_TABLES)
.acpi_name = max98357a_acpi_name,
.acpi_fill_ssdt = max98357a_fill_ssdt,