sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x86 cache-as-ram: Remove BROKEN_CAR_MIGRATE option

Browse Source 
This was added to handle cases of Intel FSP platforms that had
EARLY_CBMEM_INIT but could not migrate CAR variables to CBMEM.
These boards were recently fixed.

To support combination of EARLY_CBMEM_INIT without CAR migration was
added maintenance effort with little benefits. You had no CBMEM
console for romstage and the few timestamps you could store were
circulated via PCI scratchpads or CMOS nvram.

Change-Id: I5cffb7f2b14c45b67ee70cf48be4d7a4c9e5f761
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/8636
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@google.com>
This commit is contained in:
Kyösti Mälkki
2015-03-10 07:25:35 +02:00
parent f48b38b8d7
commit a63719407f
9 changed files with 3 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/arch/x86/Kconfig
View File

@@ -51,16 +51,8 @@ config ROMCC
bool
default n
config BROKEN_CAR_MIGRATE
def_bool n
help
Many boards use CAR_GLOBAL but have no EARLY_CBMEM_INIT and
manage CAR migration on S3 resume path only. Couple boards use
CAR_GLOBAL and never do CAR migration.
config LATE_CBMEM_INIT
def_bool n
select BROKEN_CAR_MIGRATE
help
Enable this in chipset's Kconfig if northbridge does not implement
early get_top_of_ram() call for romstage. CBMEM tables will be