Do full flush on uart8250 only at end of printk.
The previous code does a full flush of the uart after every character. Unfortunately, this can cause transmission delays on some serial ports. This patch changes the code so that it does a flush at the end of every printk instead of at the end of every character. This reduces the time it takes to transmit serial messages (up to 9% on my Asrock e350m1 board). It also makes the transmission time more consistent which is important when performing timing tests via serial transmissions. Change-Id: I6b28488b905da68c6d68d7c517cc743cde567d70 Signed-off-by: Kevin O'Connor <kevin@koconnor.net> Reviewed-on: http://review.coreboot.org/90 Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org> Tested-by: build bot (Jenkins) Reviewed-by: Rudolf Marek <r.marek@assembler.cz> Reviewed-by: Sven Schnelle <svens@stackframe.org>
This commit is contained in:
committed by
Patrick Georgi
parent
537cacfa04
commit
a68555f48d
@@ -48,7 +48,10 @@ void uart8250_tx_byte(unsigned base_port, unsigned char data)
|
||||
{
|
||||
uart8250_wait_to_tx_byte(base_port);
|
||||
outb(data, base_port + UART_TBR);
|
||||
/* Make certain the data clears the fifos */
|
||||
}
|
||||
|
||||
void uart8250_tx_flush(unsigned base_port)
|
||||
{
|
||||
uart8250_wait_until_sent(base_port);
|
||||
}
|
||||
|
||||
|
@@ -51,7 +51,10 @@ void uart8250_mem_tx_byte(unsigned base_port, unsigned char data)
|
||||
{
|
||||
uart8250_mem_wait_to_tx_byte(base_port);
|
||||
write8(base_port + UART_TBR, data);
|
||||
/* Make certain the data clears the FIFOs */
|
||||
}
|
||||
|
||||
void uart8250_mem_tx_flush(unsigned base_port)
|
||||
{
|
||||
uart8250_mem_wait_until_sent(base_port);
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user