sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vboot: Clean up vboot code

Browse Source 
1. Remove unused functions/structures.
2. Add checks for NULL return values.
3. Change prefixes to vb2 instead of vboot for functions used internally
within vboot2/
4. Get rid of vboot_handoff.h file and move the structure definition to
vboot_common.h
5. Rename all functions using handoff structure to have prefix
vboot_handoff_*. All the handoff functions can be run _only_ after cbmem
is online.
6. Organize vboot_common.h content according to different
functionalities.

BUG=chrome-os-partner:55431

Change-Id: I4c07d50327d88cddbdfbb0b6f82c264e2b8620eb
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/15799
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins)
This commit is contained in:
Furquan Shaikh
2016-07-22 06:59:40 -07:00
parent 610a33a7f4
commit a6c5ddd595
14 changed files with 106 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/soc/intel/skylake/fsp_reset.c
View File

@@ -13,7 +13,7 @@
* GNU General Public License for more details.
*/
#include <bootstate.h>
#include <vendorcode/google/chromeos/vboot_handoff.h>
#include <vendorcode/google/chromeos/vboot_common.h>
static int is_recovery; /* flag to identify recovery mode */
@@ -35,8 +35,10 @@ static void set_recovery_request(void *unused)
* Set recovery flag during Recovery Mode Silicon Init
* & store recovery request into VBNV
*/
if (is_recovery)
set_recovery_mode_into_vbnv(vboot_recovery_reason());
if (is_recovery) {
int reason = vboot_handoff_get_recovery_reason();
set_recovery_mode_into_vbnv(reason);
}
}