sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util: Drop flashrom -p host alias which equals to -p internal

Browse Source 
There is a technical debt in ChromeOS flashrom, `cros_alias.c`, which
is to work around ChromeOS calling flashrom with `-p host` instead of
`-p internal`.

Replace all `-p host` occurrences with `-p internal`.

BUG=b:296978620
TEST=none

Signed-off-by: Hsuan Ting Chen <roccochen@chromium.org>
Change-Id: I81674213b9a21598002f349ced1130f0844841ca
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77865
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Martin L Roth <gaumless@gmail.com>
This commit is contained in:
Hsuan Ting Chen
2023-09-14 11:46:20 +08:00
committed by Felix Held
parent 056952ef14
commit a6d6818f78
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
util/cbfstool/flashrom.c
View File

@ -21,7 +21,7 @@
#include "flashrom.h" #include "flashrom.h"
#define FLASHROM_EXEC_NAME "flashrom" #define FLASHROM_EXEC_NAME "flashrom"
#define FLASHROM_PROGRAMMER_INTERNAL_AP "host" #define FLASHROM_PROGRAMMER_INTERNAL_AP "internal"
/** /**
* Helper to create a temporary file. * Helper to create a temporary file.

4
util/mma/mma_setup_test.sh
View File

@ -86,7 +86,7 @@ show_usage() {
write_flash() { write_flash() {
printf "Writing back flash contents "${flashrom_temp_image}"\n" printf "Writing back flash contents "${flashrom_temp_image}"\n"
flashrom -p host -w "${flashrom_temp_image}" --noverify-all || \ flashrom -p internal -w "${flashrom_temp_image}" --noverify-all || \
{ {
printf "failed to read flash\n" ; printf "failed to read flash\n" ;
exit -1; exit -1;
@ -176,7 +176,7 @@ main() {
remove_file_if_exists "${flashrom_temp_image}" remove_file_if_exists "${flashrom_temp_image}"
printf "Reading flash contents to "${flashrom_temp_image}"\n" printf "Reading flash contents to "${flashrom_temp_image}"\n"
flashrom -p host -r "${flashrom_temp_image}" || \ flashrom -p internal -r "${flashrom_temp_image}" || \
{ {
printf "failed to read flash\n" ; printf "failed to read flash\n" ;
exit -1; exit -1;