sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/system76/adl: Remove duplicate PchHdaAudioLinkHdaEnable

Browse Source 
This UPD is hooked up in devicetree since commit 854bd492fcfa
("mb/{system76,msi}: Enable PchHdaAudioLinkHdaEnable via devicetree").

As these boards were in development when the change happened, they still
had the UPD set via romstage. Remove them now so they are only set in
devicetree.

Change-Id: I393e2c7b0134a31feae20f8992d7fd447ff7ee59
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80755
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jeremy Soller <jeremy@system76.com>
This commit is contained in:
Tim Crawford 2024-02-27 09:58:05 -07:00 committed by Felix Held
parent daa4fb2ca2
commit a78388508c
3 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/system76/adl/variants/lemp11/romstage.c
View File

@ -15,7 +15,6 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
}; };
const bool half_populated = false; const bool half_populated = false;
mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
mupd->FspmConfig.DmiMaxLinkSpeed = 4; mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0; mupd->FspmConfig.GpioOverride = 0;

1
src/mainboard/system76/adl/variants/oryp10/romstage.c
View File

@ -23,7 +23,6 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Set primary display to internal graphics // Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0; mupd->FspmConfig.PrimaryDisplay = 0;
mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
mupd->FspmConfig.DmiMaxLinkSpeed = 4; mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0; mupd->FspmConfig.GpioOverride = 0;

1
src/mainboard/system76/adl/variants/oryp9/romstage.c
View File

@ -20,7 +20,6 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
// Set primary display to internal graphics // Set primary display to internal graphics
mupd->FspmConfig.PrimaryDisplay = 0; mupd->FspmConfig.PrimaryDisplay = 0;
mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
mupd->FspmConfig.DmiMaxLinkSpeed = 4; mupd->FspmConfig.DmiMaxLinkSpeed = 4;
mupd->FspmConfig.GpioOverride = 0; mupd->FspmConfig.GpioOverride = 0;