sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix warnings in coreboot utilities.

Browse Source 
- Fix some poor programming practice (breaks of strict aliasing as well
  as not checking the return value of read)
- Use PRIx64 instead of %llx to prevent compilation warnings with both
  32bit and 64bit compilers
- Use same compiler command options when linking inteltool and when
  detecting libpci for inteltool

Change-Id: I08b2e8d1bbc908f6b1f26d25cb3a4b03d818e124
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/752
Tested-by: build bot (Jenkins)
Reviewed-by: Mathias Krause <minipli@googlemail.com>
This commit is contained in:
Stefan Reinauer
2011-11-14 12:40:34 -08:00
committed by Stefan Reinauer
parent 8acbc2a886
commit a7b296d450
6 changed files with 20 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
util/inteltool/memory.c
View File

@@ -20,6 +20,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <inttypes.h>
#include "inteltool.h"
/*
@@ -130,9 +131,9 @@ int print_mchbar(struct pci_dev *nb, struct pci_access *pacc)
}
if (nb->device_id == PCI_DEVICE_ID_INTEL_82865)
printf("BAR6 = 0x%08llx (MEM)\n\n", mchbar_phys);
printf("BAR6 = 0x%08" PRIx64 " (MEM)\n\n", mchbar_phys);
else
printf("MCHBAR = 0x%08llx (MEM)\n\n", mchbar_phys);
printf("MCHBAR = 0x%08" PRIx64 " (MEM)\n\n", mchbar_phys);
for (i = 0; i < size; i += 4) {
if (*(uint32_t *)(mchbar + i))