Fix warnings in coreboot utilities.
- Fix some poor programming practice (breaks of strict aliasing as well as not checking the return value of read) - Use PRIx64 instead of %llx to prevent compilation warnings with both 32bit and 64bit compilers - Use same compiler command options when linking inteltool and when detecting libpci for inteltool Change-Id: I08b2e8d1bbc908f6b1f26d25cb3a4b03d818e124 Signed-off-by: Stefan Reinauer <reinauer@google.com> Reviewed-on: http://review.coreboot.org/752 Tested-by: build bot (Jenkins) Reviewed-by: Mathias Krause <minipli@googlemail.com>
This commit is contained in:
committed by
Stefan Reinauer
parent
8acbc2a886
commit
a7b296d450
@@ -143,7 +143,11 @@ int main(int argc, char *argv[])
|
||||
|
||||
if (fd_stat.st_size < 128) {
|
||||
lseek(fd, 127, SEEK_SET);
|
||||
write(fd, "\0", 1);
|
||||
if (write(fd, "\0", 1) != 1) {
|
||||
fprintf(stderr, "Unable to extended '%s' to its full size.\n",
|
||||
nvramtool_op_modifiers[NVRAMTOOL_MOD_USE_CMOS_FILE].param);
|
||||
exit(1);
|
||||
}
|
||||
fsync(fd);
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user