sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/braswell: ensure ACPI opregion restored on S3 with GOP init

Browse Source 
The Intel GMA ACPI opregion address needs to be set on S3 resume,
otherwise the Windows display driver fails to re-initialize correctly.
Fix by ensuring the address is set correctly regardless of display
init type used (GOP or VBIOS).

Test: build/boot on google/edgar, ensure internal display functional
following S3 resume under Windows 10.

Change-Id: I471c44e8ba4514e4a2ddf6739109b759145598ed
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/30233
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
This commit is contained in:
Matt DeVillier
2018-06-20 00:40:48 -05:00
committed by Patrick Georgi
parent e5a1a4c5d6
commit a9492a6169
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/soc/intel/braswell/Makefile.inc
View File

@@ -22,9 +22,8 @@ ramstage-y += cpu.c
ramstage-$(CONFIG_ELOG) += elog.c ramstage-$(CONFIG_ELOG) += elog.c
ramstage-y += emmc.c ramstage-y += emmc.c
ramstage-y += gpio.c ramstage-y += gpio.c
ifneq ($(CONFIG_RUN_FSP_GOP),y)
ramstage-y += gfx.c ramstage-y += gfx.c
endif
ramstage-y += gpio_support.c ramstage-y += gpio_support.c
ramstage-y += hda.c ramstage-y += hda.c
ramstage-y += iosf.c ramstage-y += iosf.c

15
src/soc/intel/braswell/gfx.c
View File

@@ -68,15 +68,16 @@ static void gfx_init(struct device *dev)
printk(BIOS_SPEW, "%s/%s (%s)\n", printk(BIOS_SPEW, "%s/%s (%s)\n",
__FILE__, __func__, dev_name(dev)); __FILE__, __func__, dev_name(dev));
/* Pre VBIOS Init */ if (!IS_ENABLED(CONFIG_RUN_FSP_GOP)) {
gfx_pre_vbios_init(dev); /* Pre VBIOS Init */
gfx_pre_vbios_init(dev);
/* Run VBIOS */ /* Run VBIOS */
pci_dev_init(dev); pci_dev_init(dev);
/* Post VBIOS Init */
gfx_post_vbios_init(dev);
/* Post VBIOS Init */
gfx_post_vbios_init(dev);
}
intel_gma_restore_opregion(); intel_gma_restore_opregion();
} }