sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/*/spd: Use normal binary numbers (0b0010) instead of special format (2b0010)

Browse Source 
This format (one hex digit, followed by 'b', followed by binary digits)
is arguably useful, but also confusing. Use the more common format
instead.

Change-Id: Ide7b0a999483a2dd863a70f8aa42cd0865e2babf
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-on: https://review.coreboot.org/23715
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Jonathan Neuschäfer 2018-02-12 12:00:45 +01:00 committed by Martin Roth
parent 0017004b06
commit a94b112aec
4 changed files with 31 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/mainboard/google/kahlee/variants/grunt/spd/Makefile.inc
View File

@ -17,18 +17,18 @@
LIB_SPD_DEPS = $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/spd/$(f).spd.hex) LIB_SPD_DEPS = $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/spd/$(f).spd.hex)
SPD_SOURCES = hynix-H5AN8G6NAFR-UH # 0b0000 SPD_SOURCES = hynix-H5AN8G6NAFR-UH # 0b0000
SPD_SOURCES += hynix-H5ANAG6NAMR-UH # 1b0001 SPD_SOURCES += hynix-H5ANAG6NAMR-UH # 0b0001
SPD_SOURCES += micron-MT40A512M16JY-083E:B # 2b0010 SPD_SOURCES += micron-MT40A512M16JY-083E:B # 0b0010
SPD_SOURCES += micron-MT40A1G16KNR-075:E # 3b0011 SPD_SOURCES += micron-MT40A1G16KNR-075:E # 0b0011
SPD_SOURCES += samsung-K4A8G165WB-BCRC # 4b0100 SPD_SOURCES += samsung-K4A8G165WB-BCRC # 0b0100
SPD_SOURCES += samsung-K4AAG165WB-MCRC # 5b0101 SPD_SOURCES += samsung-K4AAG165WB-MCRC # 0b0101
SPD_SOURCES += empty # 6b0110 SPD_SOURCES += empty # 0b0110
SPD_SOURCES += empty # 7b0111 SPD_SOURCES += empty # 0b0111
SPD_SOURCES += empty # 8b1000 SPD_SOURCES += empty # 0b1000
SPD_SOURCES += empty # 9b1001 SPD_SOURCES += empty # 0b1001
SPD_SOURCES += empty # Ab1010 SPD_SOURCES += empty # 0b1010
SPD_SOURCES += empty # Bb1011 SPD_SOURCES += empty # 0b1011
SPD_SOURCES += empty # Cb1100 SPD_SOURCES += empty # 0b1100
SPD_SOURCES += empty # Db1101 SPD_SOURCES += empty # 0b1101
SPD_SOURCES += empty # Eb1110 SPD_SOURCES += empty # 0b1110
SPD_SOURCES += empty # Fb1111 SPD_SOURCES += empty # 0b1111

4
src/mainboard/google/zoombini/variants/zoombini/spd/Makefile.inc
View File

@ -16,8 +16,8 @@
SPD_BIN = $(obj)/spd.bin SPD_BIN = $(obj)/spd.bin
SPD_SOURCES = Hynix_H9HCNNN8KUMLHR_1GB # 0b000 SPD_SOURCES = Hynix_H9HCNNN8KUMLHR_1GB # 0b000
SPD_SOURCES += Micron_MT53B512M32D2_2GB # 1b001 SPD_SOURCES += Micron_MT53B512M32D2_2GB # 0b001
SPD_SOURCES += Micron_MT53B1024M32D4_4GB # 2b010 SPD_SOURCES += Micron_MT53B1024M32D4_4GB # 0b010
ifeq ($(SPD_SOURCES),) ifeq ($(SPD_SOURCES),)
SPD_DEPS := $(error SPD_SOURCES is not set. Variant must provide this) SPD_DEPS := $(error SPD_SOURCES is not set. Variant must provide this)

14
src/mainboard/intel/cannonlake_rvp/spd/Makefile.inc
View File

@ -19,10 +19,10 @@ romstage-y += spd_util.c
SPD_BIN = $(obj)/spd.bin SPD_BIN = $(obj)/spd.bin
SPD_SOURCES = empty # 0b000 SPD_SOURCES = empty # 0b000
SPD_SOURCES += samsung_ddr4_4GB # 1b001 Dual Channel 4GB SPD_SOURCES += samsung_ddr4_4GB # 0b001 Dual Channel 4GB
SPD_SOURCES += samsung_lpddr4_8GB # 2b001 Dual Channel 8GB SPD_SOURCES += samsung_lpddr4_8GB # 0b001 Dual Channel 8GB
SPD_SOURCES += empty # 3b011 SPD_SOURCES += empty # 0b011
SPD_SOURCES += empty # 4b100 SPD_SOURCES += empty # 0b100
SPD_SOURCES += empty # 5b101 SPD_SOURCES += empty # 0b101
SPD_SOURCES += empty # 6b110 SPD_SOURCES += empty # 0b110
SPD_SOURCES += empty # 7b111 SPD_SOURCES += empty # 0b111

14
src/mainboard/intel/kblrvp/spd/Makefile.inc
View File

@ -19,10 +19,10 @@ romstage-y += spd_util.c
SPD_BIN = $(obj)/spd.bin SPD_BIN = $(obj)/spd.bin
SPD_SOURCES = rvp3 # 0b000 Dual Channel 4GB SPD_SOURCES = rvp3 # 0b000 Dual Channel 4GB
SPD_SOURCES += empty # 1b001 SPD_SOURCES += empty # 0b001
SPD_SOURCES += empty # 2b010 SPD_SOURCES += empty # 0b010
SPD_SOURCES += empty # 3b011 SPD_SOURCES += empty # 0b011
SPD_SOURCES += empty # 4b100 SPD_SOURCES += empty # 0b100
SPD_SOURCES += empty # 5b101 SPD_SOURCES += empty # 0b101
SPD_SOURCES += hynix_dimm_H9CCNNNBJTMLAR # 6b110 Dual Channel 8GB SPD_SOURCES += hynix_dimm_H9CCNNNBJTMLAR # 0b110 Dual Channel 8GB
SPD_SOURCES += empty # 7b111 SPD_SOURCES += empty # 0b111