sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

acpi: Fix dptf_write_fan_perf to include Revision field

Browse Source 
When emitting a fan's _FPS (Fan Performance States) table, the revision
field was missing. According to ACPI spec 6.3, the current revision is
zero, so add that Package entry before the others.

BUG=b:149722146
TEST=verified first element of \_SB.DPTF.TFN1._FPS is 0

Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Change-Id: If16d4751f1d924807f5087d93b348e58d5265197
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43978
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Tim Wawrzynczak
2020-07-27 13:51:04 -06:00
parent 82ec61e9d7
commit a9d3e652f7
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/acpi/acpigen_dptf.c
View File

@@ -17,6 +17,7 @@ enum {
DEFAULT_TRIP_POINT = 0xFFFFFFFFull, DEFAULT_TRIP_POINT = 0xFFFFFFFFull,
DEFAULT_WEIGHT = 100, DEFAULT_WEIGHT = 100,
DPTF_MAX_ART_THRESHOLDS = 10, DPTF_MAX_ART_THRESHOLDS = 10,
FPS_REVISION = 0,
PPCC_REVISION = 2, PPCC_REVISION = 2,
RAPL_PL1_INDEX = 0, RAPL_PL1_INDEX = 0,
RAPL_PL2_INDEX = 1, RAPL_PL2_INDEX = 1,
@@ -353,7 +354,8 @@ void dptf_write_fan_perf(const struct dptf_fan_perf *states, int max_count)
/* _FPS - Fan Performance States */ /* _FPS - Fan Performance States */
acpigen_write_name("_FPS"); acpigen_write_name("_FPS");
pkg_count = acpigen_write_package(0); pkg_count = acpigen_write_package(1); /* 1 for Revision */
acpigen_write_integer(FPS_REVISION); /* revision */
for (i = 0; i < max_count; ++i) { for (i = 0; i < max_count; ++i) {
/* /*