mb/google/brya/nivviks: Enable ISH driver and firmware name

BRANCH=none
BUG=b:234776154
TEST=build and boot Nirwen UFS, copy ISH firmware to host
file system /lib/firmware/intel/adln_ish.bin
check "dmesg |grep ish", it should show:
ish-loader: ISH firmware intel/adlnrvp_ish.bin loaded

Signed-off-by: Meera Ravindranath <meera.ravindranath@intel.com>
Change-Id: I89782b0b7dde1fca0130472a38628e72dfd5c26c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68164
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Reka Norman <rekanorman@chromium.org>

src/drivers/intel/ish/ish.c

@@ -56,6 +56,7 @@ static const unsigned short pci_device_ids[] = {
 	PCI_DID_INTEL_CML_ISHB,
 	PCI_DID_INTEL_TGL_ISHB,
 	PCI_DID_INTEL_TGL_H_ISHB,
+	PCI_DID_INTEL_ADL_N_ISHB,
 	0
 };
 

src/include/device/pci_ids.h

@@ -2182,6 +2182,7 @@
 #define PCI_DID_INTEL_TGL_ISHB		0xa0fc
 #define PCI_DID_INTEL_TGL_H_ISHB	0x43fc
 #define PCI_DID_INTEL_MTL_ISHB		0x7e45
+#define PCI_DID_INTEL_ADL_N_ISHB	0x54fc
 
 /* Intel 82371FB (PIIX) */
 #define PCI_DID_INTEL_82371FB_ISA		0x122e

src/mainboard/google/brya/Kconfig

@@ -65,6 +65,7 @@ config BOARD_GOOGLE_BASEBOARD_NISSA
 	select BOARD_GOOGLE_BRYA_COMMON
 	select BOARD_ROMSIZE_KB_16384 if !BOARD_ROMSIZE_KB_32768
 	select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if CHROMEOS
+	select DRIVERS_INTEL_ISH
 	select MEMORY_SOLDERDOWN
 	select SOC_INTEL_ALDERLAKE_PCH_N
 	select SOC_INTEL_CSE_LITE_COMPRESS_ME_RW

src/mainboard/google/brya/variants/nivviks/overridetree.cb

@@ -519,6 +519,10 @@ chip soc/intel/alderlake
 			probe STORAGE STORAGE_EMMC
 		end
 		device ref ish on
+			chip drivers/intel/ish
+				register "firmware_name" = ""adln_ish.bin""
+				device generic 0 on end
+			end
 			probe STORAGE STORAGE_UFS
 		end
 		device ref ufs on