From ac690490309ccaaf69d3eb424170d5b7b6a22e6d Mon Sep 17 00:00:00 2001 From: Elyes HAOUAS Date: Sat, 29 Jan 2022 07:59:17 +0100 Subject: [PATCH] util/lint/checkpatch.pl: Update 'commit message line length limit' Also add "coreboot" comment on our modification. Change-Id: Ida58a92457e25bac7fb89bb5882e7647f388ec01 Signed-off-by: Elyes HAOUAS Reviewed-on: https://review.coreboot.org/c/coreboot/+/61468 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- util/lint/checkpatch.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index 4d956e2244..cc42e8fb80 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -2655,15 +2655,16 @@ sub process { $commit_log_possible_stack_dump = 1; } +# coreboot: The line lengeth limit is 72 # Check for line lengths > 72 in commit log, warn once if ($in_commit_log && !$commit_log_long_line && length($line) > 72 && !($line =~ /^\s*[a-zA-Z0-9_\/\.]+\s+\|\s+\d+/ || # file delta changes - $line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ || + $line =~ /^\s*(?:[\w\.\-\+]*\/)++[\w\.\-\+]+:/ || # filename then : - $line =~ /^\s*(?:Fixes:|Link:)/i || - # A Fixes: or Link: line + $line =~ /^\s*(?:Fixes:|Link:|$signature_tags)/i || + # A Fixes: or Link: line or signature tag line $commit_log_possible_stack_dump)) { WARN("COMMIT_LOG_LONG_LINE", "Possible unwrapped commit description (prefer a maximum 72 chars per line)\n" . $herecurr);