src: use mca_clear_status function instead of open coding
Change-Id: I53413b4051b79d7c2f24b1191ce877155e654400 Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/56259 Reviewed-by: Raul Rangel <rrangel@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
@@ -15,9 +15,7 @@
|
||||
|
||||
static void model_14_init(struct device *dev)
|
||||
{
|
||||
u8 i;
|
||||
msr_t msr;
|
||||
unsigned int num_banks;
|
||||
int msrno;
|
||||
#if CONFIG(LOGICAL_CPUS)
|
||||
u32 siblings;
|
||||
@@ -59,11 +57,7 @@ static void model_14_init(struct device *dev)
|
||||
x86_enable_cache();
|
||||
|
||||
/* zero the machine check error status registers */
|
||||
num_banks = mca_get_bank_count();
|
||||
msr.lo = 0;
|
||||
msr.hi = 0;
|
||||
for (i = 0; i < num_banks; i++)
|
||||
wrmsr(IA32_MC_STATUS(i), msr);
|
||||
mca_clear_status();
|
||||
|
||||
/* Enable the local CPU APICs */
|
||||
setup_lapic();
|
||||
|
||||
@@ -18,9 +18,7 @@ static void model_15_init(struct device *dev)
|
||||
{
|
||||
printk(BIOS_DEBUG, "Model 15 Init.\n");
|
||||
|
||||
u8 i;
|
||||
msr_t msr;
|
||||
unsigned int num_banks;
|
||||
int msrno;
|
||||
unsigned int cpu_idx;
|
||||
#if CONFIG(LOGICAL_CPUS)
|
||||
@@ -58,11 +56,7 @@ static void model_15_init(struct device *dev)
|
||||
x86_enable_cache();
|
||||
|
||||
/* zero the machine check error status registers */
|
||||
num_banks = mca_get_bank_count();
|
||||
msr.lo = 0;
|
||||
msr.hi = 0;
|
||||
for (i = 0; i < num_banks; i++)
|
||||
wrmsr(IA32_MC_STATUS(i), msr);
|
||||
mca_clear_status();
|
||||
|
||||
/* Enable the local CPU APICs */
|
||||
setup_lapic();
|
||||
|
||||
@@ -17,9 +17,7 @@ static void model_16_init(struct device *dev)
|
||||
{
|
||||
printk(BIOS_DEBUG, "Model 16 Init.\n");
|
||||
|
||||
u8 i;
|
||||
msr_t msr;
|
||||
unsigned int num_banks;
|
||||
int msrno;
|
||||
#if CONFIG(LOGICAL_CPUS)
|
||||
u32 siblings;
|
||||
@@ -56,11 +54,7 @@ static void model_16_init(struct device *dev)
|
||||
x86_enable_cache();
|
||||
|
||||
/* zero the machine check error status registers */
|
||||
num_banks = mca_get_bank_count();
|
||||
msr.lo = 0;
|
||||
msr.hi = 0;
|
||||
for (i = 0; i < num_banks; i++)
|
||||
wrmsr(IA32_MC_STATUS(i), msr);
|
||||
mca_clear_status();
|
||||
|
||||
/* Enable the local CPU APICs */
|
||||
setup_lapic();
|
||||
|
||||
@@ -20,9 +20,7 @@ static void model_16_init(struct device *dev)
|
||||
{
|
||||
printk(BIOS_DEBUG, "Model 16 Init.\n");
|
||||
|
||||
u8 i;
|
||||
msr_t msr;
|
||||
unsigned int num_banks;
|
||||
u32 siblings;
|
||||
|
||||
/*
|
||||
@@ -41,11 +39,7 @@ static void model_16_init(struct device *dev)
|
||||
x86_mtrr_check();
|
||||
|
||||
/* zero the machine check error status registers */
|
||||
num_banks = mca_get_bank_count();
|
||||
msr.lo = 0;
|
||||
msr.hi = 0;
|
||||
for (i = 0; i < num_banks; i++)
|
||||
wrmsr(IA32_MC_STATUS(i), msr);
|
||||
mca_clear_status();
|
||||
|
||||
/* Enable the local CPU APICs */
|
||||
setup_lapic();
|
||||
|
||||
Reference in New Issue
Block a user